-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][test]fix flaky ZeroQueueSizeTest.testZeroQueueGetExceptionWhenReceiveBatchMessage #24630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lhotari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24630 +/- ##
=============================================
+ Coverage 36.00% 74.32% +38.32%
- Complexity 12799 33191 +20392
=============================================
Files 1825 1882 +57
Lines 142779 146854 +4075
Branches 16393 16866 +473
=============================================
+ Hits 51402 109149 +57747
+ Misses 84275 29054 -55221
- Partials 7102 8651 +1549
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…eceiveBatchMessage (apache#24630) (cherry picked from commit ba4f715) (cherry picked from commit 7081c2d)
…eceiveBatchMessage (apache#24630) (cherry picked from commit ba4f715) (cherry picked from commit 7081c2d)
…eceiveBatchMessage (apache#24630) (cherry picked from commit ba4f715) (cherry picked from commit 332f1fe)
…eceiveBatchMessage (apache#24630) (cherry picked from commit ba4f715) (cherry picked from commit 332f1fe)
…eceiveBatchMessage (apache#24630) (cherry picked from commit ba4f715)
…eceiveBatchMessage (apache#24630) (cherry picked from commit ba4f715)
…eceiveBatchMessage (apache#24630)
…eceiveBatchMessage (apache#24630)
Fixes #24629
Motivation
The flakiness occurs because
batchingMaxPublishDelaywas set too short(100ms), potentially causing message sent as non-batched message, which is not expected.Modifications
set
batchingMaxPublishDelayas a very long time(10s) to ensure that all messages are sent as batch-message.Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: 3pacccccc#22