Skip to content

Conversation

@3pacccccc
Copy link
Contributor

Fixes #24629

Motivation

The flakiness occurs because batchingMaxPublishDelay was set too short(100ms), potentially causing message sent as non-batched message, which is not expected.

Modifications

set batchingMaxPublishDelay as a very long time(10s) to ensure that all messages are sent as batch-message.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: 3pacccccc#22

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Aug 14, 2025
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.32%. Comparing base (cde4948) to head (b29d595).
⚠️ Report is 290 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #24630       +/-   ##
=============================================
+ Coverage     36.00%   74.32%   +38.32%     
- Complexity    12799    33191    +20392     
=============================================
  Files          1825     1882       +57     
  Lines        142779   146854     +4075     
  Branches      16393    16866      +473     
=============================================
+ Hits          51402   109149    +57747     
+ Misses        84275    29054    -55221     
- Partials       7102     8651     +1549     
Flag Coverage Δ
inttests 26.61% <ø> (?)
systests 23.25% <ø> (-0.07%) ⬇️
unittests 73.81% <ø> (+39.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1420 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari lhotari merged commit ba4f715 into apache:master Aug 15, 2025
53 checks passed
lhotari pushed a commit that referenced this pull request Aug 15, 2025
lhotari pushed a commit that referenced this pull request Aug 15, 2025
lhotari pushed a commit that referenced this pull request Aug 15, 2025
ganesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Aug 20, 2025
…eceiveBatchMessage (apache#24630)

(cherry picked from commit ba4f715)
(cherry picked from commit 7081c2d)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Aug 20, 2025
…eceiveBatchMessage (apache#24630)

(cherry picked from commit ba4f715)
(cherry picked from commit 7081c2d)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Aug 21, 2025
…eceiveBatchMessage (apache#24630)

(cherry picked from commit ba4f715)
(cherry picked from commit 332f1fe)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Aug 26, 2025
…eceiveBatchMessage (apache#24630)

(cherry picked from commit ba4f715)
(cherry picked from commit 332f1fe)
nodece pushed a commit to ascentstream/pulsar that referenced this pull request Aug 26, 2025
Technoboy- pushed a commit to Technoboy-/pulsar that referenced this pull request Sep 10, 2025
@lhotari lhotari added this to the 4.1.0 milestone Sep 17, 2025
KannarFr pushed a commit to CleverCloud/pulsar that referenced this pull request Sep 22, 2025
walkinggo pushed a commit to walkinggo/pulsar that referenced this pull request Oct 8, 2025
@3pacccccc 3pacccccc deleted the fixFlakyBatch branch November 6, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky-test: ZeroQueueSizeTest.testZeroQueueGetExceptionWhenReceiveBatchMessage

3 participants