[improve][broker]Remove block calling that named cursor.asyncGetNth when expiring messages #24606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen expiring messages
dao-jun
reviewed
Aug 5, 2025
Member
dao-jun
left a comment
There was a problem hiding this comment.
I‘m +1 with the change, but do we need to add tests for the new methods?
Contributor
Author
I have added the same test cases that call |
lhotari
reviewed
Aug 6, 2025
...rc/main/java/org/apache/pulsar/broker/service/persistent/PersistentMessageExpiryMonitor.java
Outdated
Show resolved
Hide resolved
...broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java
Outdated
Show resolved
Hide resolved
lhotari
reviewed
Aug 6, 2025
...rc/main/java/org/apache/pulsar/broker/service/persistent/PersistentMessageExpiryMonitor.java
Outdated
Show resolved
Hide resolved
lhotari
reviewed
Aug 6, 2025
...rc/main/java/org/apache/pulsar/broker/service/persistent/PersistentMessageExpiryMonitor.java
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #24606 +/- ##
============================================
+ Coverage 74.21% 74.32% +0.11%
+ Complexity 33142 32789 -353
============================================
Files 1881 1881
Lines 146770 146814 +44
Branches 16859 16862 +3
============================================
+ Hits 108922 109125 +203
+ Misses 29181 29022 -159
Partials 8667 8667
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Technoboy-
approved these changes
Aug 8, 2025
gaozhangmin
pushed a commit
to gaozhangmin/pulsar
that referenced
this pull request
Aug 13, 2025
…hen expiring messages (apache#24606)
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Aug 14, 2025
…hen expiring messages (apache#24606)
poorbarcode
added a commit
to poorbarcode/pulsar
that referenced
this pull request
Aug 14, 2025
…hen expiring messages (apache#24606)
Technoboy-
pushed a commit
that referenced
this pull request
Aug 18, 2025
…hen expiring messages (#24606)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 21, 2025
…hen expiring messages (apache#24606) (cherry picked from commit 4a2dde2)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 26, 2025
…hen expiring messages (apache#24606) (cherry picked from commit 4a2dde2)
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
…hen expiring messages (apache#24606)
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
…hen expiring messages (apache#24606)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Broker checks TTL policies in the background per 5 minutes in a single thread. It calls a block method named
topic.isOldestMessageExpired, which causes a prolonged thread blockage.Modifications
Instead of calling a block method, call a non-blocked method
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x