[improve][io] Add dependency file name information to error message when .nar file validation fails with ZipException #24604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge when .nar file validation fails with ZipException apache#24585
This reverts commit 3205d7d.
This reverts commit 29a23fd.
Contributor
Author
lhotari
reviewed
Aug 5, 2025
Member
lhotari
left a comment
There was a problem hiding this comment.
Thanks for the contribution @falser101. Please check the review comment.
pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionFilePackage.java
Outdated
Show resolved
Hide resolved
…ge when .nar file validation fails with ZipException apache#24585
lhotari
approved these changes
Aug 6, 2025
Member
lhotari
left a comment
There was a problem hiding this comment.
LGTM. I added a e2e test and fixed checkstyle.
Member
|
/pulsarbot rerun-failure-checks |
1 similar comment
Member
|
/pulsarbot rerun-failure-checks |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24604 +/- ##
============================================
- Coverage 74.53% 74.29% -0.24%
- Complexity 32769 33150 +381
============================================
Files 1880 1881 +1
Lines 146433 146776 +343
Branches 16789 16857 +68
============================================
- Hits 109141 109048 -93
- Misses 28697 29070 +373
- Partials 8595 8658 +63
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
gaozhangmin
pushed a commit
to gaozhangmin/pulsar
that referenced
this pull request
Aug 13, 2025
…hen .nar file validation fails with ZipException (apache#24604) Co-authored-by: Lari Hotari <lhotari@apache.org>
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Aug 14, 2025
…hen .nar file validation fails with ZipException (apache#24604) Co-authored-by: Lari Hotari <lhotari@apache.org>
poorbarcode
pushed a commit
to poorbarcode/pulsar
that referenced
this pull request
Aug 14, 2025
…hen .nar file validation fails with ZipException (apache#24604) Co-authored-by: Lari Hotari <lhotari@apache.org>
Technoboy-
pushed a commit
that referenced
this pull request
Aug 18, 2025
…hen .nar file validation fails with ZipException (#24604) Co-authored-by: Lari Hotari <lhotari@apache.org>
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 20, 2025
…hen .nar file validation fails with ZipException (apache#24604) Co-authored-by: Lari Hotari <lhotari@apache.org> (cherry picked from commit 2d5b0d6) (cherry picked from commit a85e92c)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 20, 2025
…hen .nar file validation fails with ZipException (apache#24604) Co-authored-by: Lari Hotari <lhotari@apache.org> (cherry picked from commit 2d5b0d6) (cherry picked from commit a85e92c)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 21, 2025
…hen .nar file validation fails with ZipException (apache#24604) Co-authored-by: Lari Hotari <lhotari@apache.org> (cherry picked from commit 796603e)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 26, 2025
…hen .nar file validation fails with ZipException (apache#24604) Co-authored-by: Lari Hotari <lhotari@apache.org> (cherry picked from commit 796603e)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Aug 26, 2025
…hen .nar file validation fails with ZipException (apache#24604) Co-authored-by: Lari Hotari <lhotari@apache.org> (cherry picked from commit 2d5b0d6)
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
…hen .nar file validation fails with ZipException (apache#24604) Co-authored-by: Lari Hotari <lhotari@apache.org>
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
…hen .nar file validation fails with ZipException (apache#24604) Co-authored-by: Lari Hotari <lhotari@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24585
Documentation
docdoc-requireddoc-not-neededdoc-complete