Skip to content

[improve][broker]Part-2 Add Admin API to delete topic policies #24602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
poorbarcode merged 1 commit into from
Aug 9, 2025
Merged

[improve][broker]Part-2 Add Admin API to delete topic policies #24602

poorbarcode merged 1 commit into from
Aug 9, 2025

Conversation

@poorbarcode
Copy link
Contributor

@poorbarcode poorbarcode commented Aug 4, 2025 •
edited
Loading

Motivation

See the PIP-422

pulsar-admin topicPolicies delete <topic>

Modifications

  • Add Admin API to delete topic policies

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: x

@poorbarcode poorbarcode added this to the 4.1.0 milestone Aug 4, 2025
@poorbarcode poorbarcode self-assigned this Aug 4, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Aug 4, 2025
@Technoboy- Technoboy- closed this Aug 7, 2025
@Technoboy- Technoboy- reopened this Aug 7, 2025
@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 56.52174% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.25%. Comparing base (d272825) to head (d55ca26).
⚠️ Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
...pache/pulsar/broker/admin/v2/PersistentTopics.java 46.15% 7 Missing ⚠️
.../org/apache/pulsar/admin/cli/CmdTopicPolicies.java 40.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24602      +/-   ##
============================================
+ Coverage     74.21%   74.25%   +0.04%     
+ Complexity    33142    32759     -383     
============================================
  Files          1881     1881              
  Lines        146770   146799      +29     
  Branches      16859    16859              
============================================
+ Hits         108922   109006      +84     
+ Misses        29181    29141      -40     
+ Partials       8667     8652      -15
Flag Coverage Δ
inttests 26.63% <0.00%> (?)
systests 23.27% <0.00%> (-0.08%) ⬇️
unittests 73.74% <56.52%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../org/apache/pulsar/client/admin/TopicPolicies.java 100.00% <ø> (ø)
...ulsar/client/admin/internal/TopicPoliciesImpl.java 96.11% <100.00%> (+0.04%) ⬆️
.../org/apache/pulsar/admin/cli/CmdTopicPolicies.java 88.34% <40.00%> (-0.36%) ⬇️
...pache/pulsar/broker/admin/v2/PersistentTopics.java 87.97% <46.15%> (-0.16%) ⬇️

... and 102 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@poorbarcode poorbarcode merged commit ed10ec3 into apache:master Aug 9, 2025
146 of 159 checks passed
@lhotari lhotari mentioned this pull request Aug 11, 2025
Closed
gaozhangmin pushed a commit to gaozhangmin/pulsar that referenced this pull request Aug 13, 2025
@poorbarcode
[improve][broker]Part-2 Add Admin API to delete topic policies (apach…
66cbebf 
…e#24602)
poorbarcode added a commit to poorbarcode/pulsar that referenced this pull request Aug 14, 2025
@poorbarcode
[improve][broker]Part-2 Add Admin API to delete topic policies (apach…
71eea12 
…e#24602)
poorbarcode added a commit that referenced this pull request Aug 20, 2025
@poorbarcode
[improve][broker]Part-2 Add Admin API to delete topic policies (#24602)
43b2749 
(cherry picked from commit ed10ec3)
@poorbarcode
Copy link
Contributor Author

poorbarcode commented Aug 20, 2025

Cherry-picked into branch-4.0

manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Aug 21, 2025
@poorbarcode @manas-ctds
[improve][broker]Part-2 Add Admin API to delete topic policies (apach…
7c3eb46 
…e#24602)

(cherry picked from commit ed10ec3)
(cherry picked from commit 43b2749)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Aug 28, 2025
@poorbarcode @manas-ctds
[improve][broker]Part-2 Add Admin API to delete topic policies (apach…
0472361 
…e#24602)

(cherry picked from commit ed10ec3)
(cherry picked from commit 43b2749)
Technoboy- pushed a commit to Technoboy-/pulsar that referenced this pull request Sep 10, 2025
@poorbarcode @Technoboy-
[improve][broker]Part-2 Add Admin API to delete topic policies (apach…
b11cafe 
…e#24602)

(cherry picked from commit ed10ec3)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Sep 12, 2025
@poorbarcode @srinath-ctds
[improve][broker]Part-2 Add Admin API to delete topic policies (apach…
deafb10 
…e#24602)

(cherry picked from commit ed10ec3)
(cherry picked from commit 43b2749)
KannarFr pushed a commit to CleverCloud/pulsar that referenced this pull request Sep 22, 2025
@poorbarcode @KannarFr
[improve][broker]Part-2 Add Admin API to delete topic policies (apach…
2c6a357 
…e#24602)
walkinggo pushed a commit to walkinggo/pulsar that referenced this pull request Oct 8, 2025
@poorbarcode @walkinggo
[improve][broker]Part-2 Add Admin API to delete topic policies (apach…
f32e849 
…e#24602)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@shibd shibd shibd approved these changes

@lhotari lhotari Awaiting requested review from lhotari

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

@coderzc coderzc Awaiting requested review from coderzc

Assignees

@poorbarcode poorbarcode

Labels

cherry-picked/branch-4.0 doc-not-needed Your PR changes do not impact docs ready-to-test release/4.0.7

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@poorbarcode @codecov-commenter @Technoboy- @shibd