[fix][ci] Fix code coverage metrics in Pulsar CI #24595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
approved these changes
Jul 31, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24595 +/- ##
============================================
+ Coverage 73.57% 74.39% +0.81%
- Complexity 32624 33070 +446
============================================
Files 1877 1880 +3
Lines 139502 146422 +6920
Branches 15299 16786 +1487
============================================
+ Hits 102638 108926 +6288
+ Misses 28908 28854 -54
- Partials 7956 8642 +686
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
lhotari
added a commit
that referenced
this pull request
Aug 4, 2025
(cherry picked from commit 9543bda)
lhotari
added a commit
that referenced
this pull request
Aug 4, 2025
(cherry picked from commit 9543bda)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Aug 6, 2025
(cherry picked from commit 9543bda)
gaozhangmin
pushed a commit
to gaozhangmin/pulsar
that referenced
this pull request
Aug 13, 2025
poorbarcode
pushed a commit
to poorbarcode/pulsar
that referenced
this pull request
Aug 14, 2025
lhotari
added a commit
that referenced
this pull request
Sep 16, 2025
(cherry picked from commit 9543bda)
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Codecov metrics have been broken for Pulsar CI since the scheduled master branch build cannot upload metrics without a token. This PR passes the token provided in secrets to the Codecov action. The
CODECOV_TOKENsecret has been added toapache/pulsarrepository. This token is only used forapache/pulsarbranch builds. For PR branch builds, uploads haven't been a problem and that could happen without a token or with the user provided token.Additional information:
The
CODECOV_TOKENsecret was added toapache/pulsarat https://github.com/apache/pulsar/settings/secrets/actions. The token value is available at https://app.codecov.io/gh/apache/pulsar/config/general for apache/pulsar committers after using GitHub login to login to Codecov.Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete