Skip to content

[improve][client] Support load RSA PKCS#8 private key #24582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codelipenghui merged 2 commits into from
Jul 30, 2025
Merged

[improve][client] Support load RSA PKCS#8 private key #24582

codelipenghui merged 2 commits into from
Jul 30, 2025
+51 −2

Conversation

@gaoran10
Copy link
Contributor

@gaoran10 gaoran10 commented Jul 30, 2025 •
edited
Loading

Motivation

Currently, the Java client only supports loading RSA PKCS#1 format private keys.

Modifications

Support loading RSA PKCS#8 format private key.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@gaoran10 gaoran10 changed the title [improve][client] Support RSA PKCS#8 format [improve][client] Support load RSA PKCS#8 private key Jul 30, 2025
@gaoran10 gaoran10 self-assigned this Jul 30, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jul 30, 2025
lhotari
lhotari approved these changes Jul 30, 2025
View reviewed changes
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari added this to the 4.1.0 milestone Jul 30, 2025
@codelipenghui
Copy link
Contributor

codelipenghui commented Jul 30, 2025

/pulsarbot run-failure-checks

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.33%. Comparing base (bbc6224) to head (8799f1f).
⚠️ Report is 1250 commits behind head on master.

Files with missing lines Patch % Lines
...che/pulsar/client/impl/crypto/MessageCryptoBc.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24582      +/-   ##
============================================
+ Coverage     73.57%   74.33%   +0.76%     
- Complexity    32624    32671      +47     
============================================
  Files          1877     1880       +3     
  Lines        139502   146422    +6920     
  Branches      15299    16786    +1487     
============================================
+ Hits         102638   108847    +6209     
- Misses        28908    28917       +9     
- Partials       7956     8658     +702
Flag Coverage Δ
inttests 26.92% <0.00%> (+2.33%) ⬆️
systests 23.41% <0.00%> (-0.92%) ⬇️
unittests 73.82% <66.66%> (+0.97%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...che/pulsar/client/impl/crypto/MessageCryptoBc.java 69.26% <66.66%> (+1.13%) ⬆️

... and 1113 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codelipenghui codelipenghui merged commit 8cf353f into apache:master Jul 30, 2025
140 of 145 checks passed
Technoboy- pushed a commit that referenced this pull request Jul 31, 2025
@gaoran10 @Technoboy-
[improve][client] Support load RSA PKCS#8 private key (#24582)
8010947
lhotari pushed a commit that referenced this pull request Aug 4, 2025
@gaoran10 @lhotari
[improve][client] Support load RSA PKCS#8 private key (#24582)
b3d5366 
(cherry picked from commit 8cf353f)
lhotari pushed a commit that referenced this pull request Aug 4, 2025
@gaoran10 @lhotari
[improve][client] Support load RSA PKCS#8 private key (#24582)
1b9b6ae 
(cherry picked from commit 8cf353f)
nodece pushed a commit to ascentstream/pulsar that referenced this pull request Aug 6, 2025
@gaoran10 @nodece
[improve][client] Support load RSA PKCS#8 private key (apache#24582)
1d8061f 
(cherry picked from commit 8cf353f)
gaozhangmin pushed a commit to gaozhangmin/pulsar that referenced this pull request Aug 13, 2025
@gaoran10
[improve][client] Support load RSA PKCS#8 private key (apache#24582)
6727ad1
poorbarcode pushed a commit to poorbarcode/pulsar that referenced this pull request Aug 14, 2025
@gaoran10 @poorbarcode
[improve][client] Support load RSA PKCS#8 private key (apache#24582)
5b75492
ganesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Aug 20, 2025
@gaoran10 @ganesh-ctds
[improve][client] Support load RSA PKCS#8 private key (apache#24582)
3aca58c 
(cherry picked from commit 8cf353f)
(cherry picked from commit 1b9b6ae)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Aug 20, 2025
@gaoran10 @srinath-ctds
[improve][client] Support load RSA PKCS#8 private key (apache#24582)
4f49406 
(cherry picked from commit 8cf353f)
(cherry picked from commit 1b9b6ae)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Aug 20, 2025
@gaoran10 @manas-ctds
[improve][client] Support load RSA PKCS#8 private key (apache#24582)
85b84df 
(cherry picked from commit 8010947)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Aug 26, 2025
@gaoran10 @srinath-ctds
[improve][client] Support load RSA PKCS#8 private key (apache#24582)
89daaef 
(cherry picked from commit 8010947)
KannarFr pushed a commit to CleverCloud/pulsar that referenced this pull request Sep 22, 2025
@gaoran10 @KannarFr
[improve][client] Support load RSA PKCS#8 private key (apache#24582)
2da1cc3
walkinggo pushed a commit to walkinggo/pulsar that referenced this pull request Oct 8, 2025
@gaoran10 @walkinggo
[improve][client] Support load RSA PKCS#8 private key (apache#24582)
dab7d06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhotari lhotari lhotari approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@BewareMyPower BewareMyPower Awaiting requested review from BewareMyPower

@saandrews saandrews Awaiting requested review from saandrews

@poorbarcode poorbarcode Awaiting requested review from poorbarcode

Assignees

@gaoran10 gaoran10

Labels

area/client cherry-picked/branch-3.0 cherry-picked/branch-3.3 cherry-picked/branch-4.0 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.14 release/3.3.9 release/4.0.7

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@gaoran10 @codelipenghui @codecov-commenter @lhotari @Technoboy-