[fix][broker] Fix maxTopicsPerNamespace might report a false failure #24560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
approved these changes
Jul 25, 2025
Member
lhotari
left a comment
There was a problem hiding this comment.
LGTM, good work @BewareMyPower
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24560 +/- ##
============================================
+ Coverage 73.57% 74.33% +0.76%
- Complexity 32624 32973 +349
============================================
Files 1877 1876 -1
Lines 139502 146276 +6774
Branches 15299 16774 +1475
============================================
+ Hits 102638 108739 +6101
+ Misses 28908 28899 -9
- Partials 7956 8638 +682
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
Author
|
I see 4.0.6 has not started the release, change the release label to 4.0.6 |
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Jul 28, 2025
…pache#24560) (cherry picked from commit 1c5c765)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Jul 28, 2025
…pache#24560) (cherry picked from commit 1c5c765)
priyanshu-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 28, 2025
…pache#24560) (cherry picked from commit 1c5c765) (cherry picked from commit 3bd2794)
priyanshu-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 28, 2025
…pache#24560) (cherry picked from commit 1c5c765) (cherry picked from commit 125a33f)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 29, 2025
…pache#24560) (cherry picked from commit 1c5c765) (cherry picked from commit 125a33f)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 30, 2025
…pache#24560) (cherry picked from commit 1c5c765) (cherry picked from commit 125a33f)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 31, 2025
…pache#24560) (cherry picked from commit 1c5c765) (cherry picked from commit 3bd2794)
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
createIfMissingargument only represents the topic can be created automatically when it does not exist, but it might not trigger the topic creation in thisgetTopiccall. Hence, we cannot simply pass 1 as the 2nd argument here:pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Line 1790 in d95cf3f
Assuming
maxTopicsPerNamespaceis 10, then the following two cases will both fail.Case 1:
Case 2:
Modifications
Add an overload of
checkMaxTopicsPerNamespace, which verifies if the topic exists first. Only call the other overload when the topic does not exist. IncreatePersistentTopic0, call this new overload. ImprovetestMaxTopicsPerNamespaceto verify this change.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: