[improve][test] Remove EntryCacheCreator from ManagedLedgerFactoryImpl #24552
+37
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 23, 2025
lhotari
added a commit
to lhotari/pulsar
that referenced
this pull request
Jul 23, 2025
BewareMyPower
approved these changes
Jul 24, 2025
dao-jun
approved these changes
Jul 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24552 +/- ##
============================================
+ Coverage 73.57% 74.33% +0.75%
+ Complexity 32624 32587 -37
============================================
Files 1877 1874 -3
Lines 139502 146226 +6724
Branches 15299 16771 +1472
============================================
+ Hits 102638 108692 +6054
- Misses 28908 28909 +1
- Partials 7956 8625 +669
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
priyanshu-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 24, 2025
apache#24552) (cherry picked from commit 07af143) (cherry picked from commit 288633b)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 24, 2025
apache#24552) (cherry picked from commit 07af143) (cherry picked from commit 288633b)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Jul 28, 2025
apache#24552) (cherry picked from commit 07af143)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Jul 28, 2025
apache#24552) (cherry picked from commit 07af143)
priyanshu-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 28, 2025
apache#24552) (cherry picked from commit 07af143) (cherry picked from commit 05ea80c)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 31, 2025
apache#24552) (cherry picked from commit 07af143) (cherry picked from commit 05ea80c)
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In PR #24515, a change was made to ManagedLedgerFactoryImpl for testing the changes by adding a new parameter "EntryCacheCreator" to ManagedLedgerFactoryImpl. This conflicts with #24363 changes and one of the conflicts is that the EntryCache instance isn't designed to be instantiated on it's own and I'd like to keep the implementation details in package protected classes. There would be unnecessary complexity just to support this particular testing use cases.
There's already a way to test such changes with the PulsarMockReadHandleInterceptor which is supported by PulsarMockBookKeeper. This is why adding the "EntryCacheCreator" is not necessary.
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete