-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][broker] Fix matching of topicsPattern for topic names which contain non-ascii characters #24543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lhotari
merged 1 commit into
apache:master
from
lhotari:lh-fix-url-encoded-topic-name-in-watcher
Jul 22, 2025
Merged
[fix][broker] Fix matching of topicsPattern for topic names which contain non-ascii characters #24543
lhotari
merged 1 commit into
apache:master
from
lhotari:lh-fix-url-encoded-topic-name-in-watcher
Jul 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tain non ascii characters
BewareMyPower
approved these changes
Jul 22, 2025
Technoboy-
approved these changes
Jul 22, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24543 +/- ##
============================================
+ Coverage 73.57% 74.25% +0.68%
+ Complexity 32624 32537 -87
============================================
Files 1877 1869 -8
Lines 139502 146115 +6613
Branches 15299 16761 +1462
============================================
+ Hits 102638 108504 +5866
- Misses 28908 28988 +80
- Partials 7956 8623 +667
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
priyanshu-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 24, 2025
…tain non-ascii characters (apache#24543) (cherry picked from commit de53c29) (cherry picked from commit f604a14)
priyanshu-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 24, 2025
…tain non-ascii characters (apache#24543) (cherry picked from commit de53c29) (cherry picked from commit f604a14)
priyanshu-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 24, 2025
…tain non-ascii characters (apache#24543) (cherry picked from commit de53c29) (cherry picked from commit 0a21e64)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 24, 2025
…tain non-ascii characters (apache#24543) (cherry picked from commit de53c29) (cherry picked from commit f604a14)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 24, 2025
…tain non-ascii characters (apache#24543) (cherry picked from commit de53c29) (cherry picked from commit 0a21e64)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Jul 28, 2025
…tain non-ascii characters (apache#24543) (cherry picked from commit de53c29)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Jul 28, 2025
…tain non-ascii characters (apache#24543) (cherry picked from commit de53c29)
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
…tain non-ascii characters (apache#24543)
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
…tain non-ascii characters (apache#24543)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.13
release/3.3.8
release/4.0.6
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24182
Motivation
When using
topicsPatternconsumer, the pattern wouldn't properly match topic names which contain non-ascii characters.Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete