Skip to content

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Jul 22, 2025

Fixes #24182

Motivation

When using topicsPattern consumer, the pattern wouldn't properly match topic names which contain non-ascii characters.

Modifications

  • decode the url encoded persistent topic name before passing it to the listener
  • add a unit test

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@BewareMyPower BewareMyPower added the type/bug The PR fixed a bug or issue reported a bug label Jul 22, 2025
@lhotari lhotari requested a review from poorbarcode July 22, 2025 13:32
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.25%. Comparing base (bbc6224) to head (54cd8bb).
⚠️ Report is 1311 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24543      +/-   ##
============================================
+ Coverage     73.57%   74.25%   +0.68%     
+ Complexity    32624    32537      -87     
============================================
  Files          1877     1869       -8     
  Lines        139502   146115    +6613     
  Branches      15299    16761    +1462     
============================================
+ Hits         102638   108504    +5866     
- Misses        28908    28988      +80     
- Partials       7956     8623     +667     
Flag Coverage Δ
inttests 26.77% <0.00%> (+2.19%) ⬆️
systests 23.25% <0.00%> (-1.08%) ⬇️
unittests 73.75% <100.00%> (+0.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...apache/pulsar/broker/resources/TopicResources.java 100.00% <100.00%> (+3.38%) ⬆️

... and 1103 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari lhotari merged commit de53c29 into apache:master Jul 22, 2025
144 of 150 checks passed
lhotari added a commit that referenced this pull request Jul 22, 2025
…tain non-ascii characters (#24543)

(cherry picked from commit de53c29)
lhotari added a commit that referenced this pull request Jul 23, 2025
…tain non-ascii characters (#24543)

(cherry picked from commit de53c29)
lhotari added a commit that referenced this pull request Jul 23, 2025
…tain non-ascii characters (#24543)

(cherry picked from commit de53c29)
priyanshu-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 24, 2025
…tain non-ascii characters (apache#24543)

(cherry picked from commit de53c29)
(cherry picked from commit f604a14)
priyanshu-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 24, 2025
…tain non-ascii characters (apache#24543)

(cherry picked from commit de53c29)
(cherry picked from commit f604a14)
priyanshu-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 24, 2025
…tain non-ascii characters (apache#24543)

(cherry picked from commit de53c29)
(cherry picked from commit 0a21e64)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 24, 2025
…tain non-ascii characters (apache#24543)

(cherry picked from commit de53c29)
(cherry picked from commit f604a14)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 24, 2025
…tain non-ascii characters (apache#24543)

(cherry picked from commit de53c29)
(cherry picked from commit 0a21e64)
nodece pushed a commit to ascentstream/pulsar that referenced this pull request Jul 28, 2025
nodece pushed a commit to ascentstream/pulsar that referenced this pull request Jul 28, 2025
KannarFr pushed a commit to CleverCloud/pulsar that referenced this pull request Sep 22, 2025
walkinggo pushed a commit to walkinggo/pulsar that referenced this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] watch topic not support url encode char

4 participants