Skip to content

Conversation

@codelipenghui
Copy link
Contributor

@codelipenghui codelipenghui commented Jul 18, 2025

Summary

  • Add a new test testDeadLetterTopicWithMaxUnackedMessagesBlocking to verify dead letter topic functionality when max unacked messages constraints are applied
  • The test ensures that messages eventually reach the DLQ even with flow control limitations
  • Tests the interaction between dead letter policy and max unacked messages settings

Test Plan

  • New test passes locally
  • Test verifies proper DLQ behavior under flow control constraints
  • Test includes proper logging for debugging flow control interactions

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

🤖 Generated with Claude Code

@github-actions
Copy link

@codelipenghui Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@codelipenghui codelipenghui changed the title [test] Add test for dead letter topic with max unacked messages blocking [improve][test] Add test for dead letter topic with max unacked messages blocking Jul 18, 2025
@codelipenghui codelipenghui self-assigned this Jul 18, 2025
@codelipenghui codelipenghui added this to the 4.1.0 milestone Jul 18, 2025
@codelipenghui
Copy link
Contributor Author

/pulsarbot run-failure-checks

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Jul 18, 2025
@Technoboy-
Copy link
Contributor

/pulsarbot run-failure-checks

@codelipenghui
Copy link
Contributor Author

/pulsarbot run-failure-checks

This test verifies that the dead letter topic functionality works correctly
when max unacked messages constraints are applied, ensuring messages
eventually reach the DLQ even with flow control limitations.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@codelipenghui codelipenghui force-pushed the penghui/add-dlq-test branch from bc8b89f to 4fce81b Compare July 29, 2025 14:59
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.32%. Comparing base (bbc6224) to head (4fce81b).
⚠️ Report is 1237 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24535      +/-   ##
============================================
+ Coverage     73.57%   74.32%   +0.74%     
- Complexity    32624    33054     +430     
============================================
  Files          1877     1880       +3     
  Lines        139502   146418    +6916     
  Branches      15299    16784    +1485     
============================================
+ Hits         102638   108821    +6183     
- Misses        28908    28954      +46     
- Partials       7956     8643     +687     
Flag Coverage Δ
inttests 26.68% <ø> (+2.10%) ⬆️
systests 23.39% <ø> (-0.93%) ⬇️
unittests 73.82% <ø> (+0.97%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1113 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codelipenghui codelipenghui merged commit 16a43c6 into apache:master Jul 29, 2025
50 checks passed
Technoboy- pushed a commit that referenced this pull request Jul 31, 2025
lhotari pushed a commit that referenced this pull request Aug 4, 2025
lhotari pushed a commit that referenced this pull request Aug 4, 2025
nodece pushed a commit to ascentstream/pulsar that referenced this pull request Aug 6, 2025
poorbarcode pushed a commit to poorbarcode/pulsar that referenced this pull request Aug 14, 2025
ganesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Aug 20, 2025
…ges blocking (apache#24535)

(cherry picked from commit 16a43c6)
(cherry picked from commit f30a4b7)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Aug 20, 2025
…ges blocking (apache#24535)

(cherry picked from commit 16a43c6)
(cherry picked from commit f30a4b7)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Aug 20, 2025
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Aug 26, 2025
KannarFr pushed a commit to CleverCloud/pulsar that referenced this pull request Sep 22, 2025
walkinggo pushed a commit to walkinggo/pulsar that referenced this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants