[fix][client] Fix issue in auto releasing of idle connection with topics pattern consumer #24528
+354
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ics pattern consumer
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24528 +/- ##
============================================
+ Coverage 73.57% 74.31% +0.74%
- Complexity 32624 32872 +248
============================================
Files 1877 1868 -9
Lines 139502 145946 +6444
Branches 15299 16737 +1438
============================================
+ Hits 102638 108465 +5827
+ Misses 28908 28866 -42
- Partials 7956 8615 +659
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
BewareMyPower
approved these changes
Jul 17, 2025
priyanshu-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 22, 2025
…ics pattern consumer (apache#24528) (cherry picked from commit 8be127f) (cherry picked from commit f16b757)
priyanshu-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 22, 2025
…ics pattern consumer (apache#24528) (cherry picked from commit 8be127f) (cherry picked from commit 1c1bf66)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 23, 2025
…ics pattern consumer (apache#24528) (cherry picked from commit 8be127f) (cherry picked from commit f16b757)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 24, 2025
…ics pattern consumer (apache#24528) (cherry picked from commit 8be127f) (cherry picked from commit 1c1bf66)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Jul 28, 2025
…ics pattern consumer (apache#24528) (cherry picked from commit 8be127f)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Jul 28, 2025
…ics pattern consumer (apache#24528) (cherry picked from commit 8be127f)
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
…ics pattern consumer (apache#24528)
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
…ics pattern consumer (apache#24528)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
"PIP-165 Auto release client useless connections" added a solution that closes unused idling connections. The idle check doesn't consider topic watchers created by a topics pattern (regex) consumer. The impact of this is that connections would get frequently closed and immediately reconnected when topics pattern consumers are used and when the topic watcher is the only resource using the connection.
While reviewing the code, another possible race condition was observed in the solution due lack of usage of volatile for ClientCnxIdleState's idleMarkTime field. The field gets mutated and read in different threads in certain cases.
There was also a concern that a currently used connection could get released under a race condition. That's why this PR adds another check before the ClientCnxIdleState can move from IDLE to RELEASING.
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete