Skip to content

Conversation

@codelipenghui
Copy link
Contributor

@codelipenghui codelipenghui commented Jul 16, 2025

Summary

This PR upgrades the Caffeine caching library from version 2.9.1 to 3.2.1 to benefit from the latest features and performance improvements.

Changes Made

  • Updated caffeine.version from 2.9.1 to 3.2.1 in the main pom.xml
  • Updated LICENSE.bin.txt files to reflect the new Caffeine version

🤖 Generated with Claude Code

This upgrade brings the latest features and performance improvements from Caffeine 3.2.1.
The change is backward compatible as existing code uses standard Caffeine APIs.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@codelipenghui codelipenghui self-assigned this Jul 16, 2025
@codelipenghui codelipenghui added this to the 4.1.0 milestone Jul 16, 2025
@codelipenghui codelipenghui added doc-not-needed Your PR changes do not impact docs release/4.0.6 labels Jul 16, 2025
@github-actions github-actions bot added doc-label-missing and removed doc-not-needed Your PR changes do not impact docs labels Jul 16, 2025
@github-actions
Copy link

@codelipenghui Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@codelipenghui codelipenghui added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Jul 16, 2025
@github-actions github-actions bot added doc-label-missing and removed doc-not-needed Your PR changes do not impact docs labels Jul 16, 2025
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can only apply this to master branch which will be following PIP-421, so that we require Java 17 for the Pulsar Java client.
In the past, the reason for not upgrading Caffeine in Pulsar due to Java 8 compatibility of the Pulsar Java client. Since Pulsar 4.0.x is Java 8 compatible, we cannot cherry-pick this upgrade to branch-4.0.

@codelipenghui
Copy link
Contributor Author

/pulsarbot run-failure-checks

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.32%. Comparing base (bbc6224) to head (9623bd7).
Report is 1197 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24527      +/-   ##
============================================
+ Coverage     73.57%   74.32%   +0.74%     
+ Complexity    32624    32501     -123     
============================================
  Files          1877     1868       -9     
  Lines        139502   145941    +6439     
  Branches      15299    16735    +1436     
============================================
+ Hits         102638   108468    +5830     
+ Misses        28908    28873      -35     
- Partials       7956     8600     +644     
Flag Coverage Δ
inttests 26.71% <ø> (+2.12%) ⬆️
systests 23.35% <ø> (-0.98%) ⬇️
unittests 73.80% <ø> (+0.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1098 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codelipenghui codelipenghui merged commit f3bcc2c into apache:master Jul 17, 2025
96 of 109 checks passed
@codelipenghui codelipenghui deleted the upgrade-caffeine-3.2.1 branch July 17, 2025 18:58
KannarFr pushed a commit to CleverCloud/pulsar that referenced this pull request Sep 22, 2025
walkinggo pushed a commit to walkinggo/pulsar that referenced this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants