[improve][broker] Extract duplication in AbstractTopic#incrementTopicEpochIfNeeded #24520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24520 +/- ##
============================================
+ Coverage 73.57% 74.28% +0.71%
+ Complexity 32624 32481 -143
============================================
Files 1877 1868 -9
Lines 139502 145909 +6407
Branches 15299 16728 +1429
============================================
+ Hits 102638 108389 +5751
- Misses 28908 28918 +10
- Partials 7956 8602 +646
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dao-jun
approved these changes
Jul 27, 2025
Technoboy-
approved these changes
Jul 29, 2025
Technoboy-
pushed a commit
that referenced
this pull request
Jul 31, 2025
poorbarcode
pushed a commit
to poorbarcode/pulsar
that referenced
this pull request
Aug 14, 2025
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 20, 2025
…EpochIfNeeded (apache#24520) (cherry picked from commit 395b55c)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 26, 2025
…EpochIfNeeded (apache#24520) (cherry picked from commit 395b55c)
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The method AbstractTopic#incrementTopicEpochIfNeeded contains significant code duplication, especially for handling producers in different modes (
Exclusive,ExclusiveWithFencing, andWaitForExclusive). This duplication makes the method overly long, harder to read, and more difficult to maintain. The goal of this PR is to improve code readability and maintainability by extracting the duplicated logic into a separate method.Modifications
Extracted the common logic for handling topic epoch updates and exclusive producer checks into a new method
handleTopicEpochForExclusiveProducer.Replaced the duplicated code blocks in the
Exclusive,ExclusiveWithFencing, andWaitForExclusivecases with calls to the new method.Verifying this change
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: 3pacccccc#14