Skip to content

Conversation

@StevenLuMT
Copy link
Member

Background

import change: org.apache.commons.lang to org.apache.commons.lang3

Modifications

  1. import change: org.apache.commons.lang to org.apache.commons.lang3
  2. add check style rules that prevent using commons-lang for new code.

Verifying this change

  • Make sure that the change passes the CI checks.
    This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: StevenLuMT#16

@liangyepianzhou liangyepianzhou requested a review from lhotari July 2, 2025 02:50
@StevenLuMT
Copy link
Member Author

/pulsarbot run-failure-checks

@codelipenghui codelipenghui added this to the 4.1.0 milestone Jul 2, 2025
@codelipenghui
Copy link
Contributor

/pulsarbot run-failure-checks

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.32%. Comparing base (bbc6224) to head (d6033d0).
Report is 1177 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24473      +/-   ##
============================================
+ Coverage     73.57%   74.32%   +0.75%     
+ Complexity    32624    32401     -223     
============================================
  Files          1877     1868       -9     
  Lines        139502   145580    +6078     
  Branches      15299    16662    +1363     
============================================
+ Hits         102638   108205    +5567     
+ Misses        28908    28810      -98     
- Partials       7956     8565     +609     
Flag Coverage Δ
inttests 26.83% <0.00%> (+2.25%) ⬆️
systests 23.34% <66.66%> (-0.99%) ⬇️
unittests 73.82% <33.33%> (+0.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../bookkeeper/mledger/MetadataCompressionConfig.java 100.00% <ø> (+12.50%) ⬆️
...hentication/oidc/AuthenticationProviderOpenID.java 75.26% <ø> (-1.53%) ⬇️
...ommon/configuration/PulsarConfigurationLoader.java 81.25% <ø> (ø)
...g/apache/pulsar/broker/admin/impl/BrokersBase.java 87.55% <ø> (+15.10%) ⬆️
...pache/pulsar/broker/admin/impl/NamespacesBase.java 76.09% <ø> (+3.01%) ⬆️
.../pulsar/broker/admin/impl/SchemasResourceBase.java 90.99% <ø> (+0.33%) ⬆️
.../prometheus/metrics/PrometheusMetricsProvider.java 71.87% <ø> (ø)
...java/org/apache/pulsar/admin/cli/CmdFunctions.java 49.80% <ø> (+3.59%) ⬆️
...ache/pulsar/client/impl/ZeroQueueConsumerImpl.java 65.43% <ø> (ø)
.../client/impl/auth/oauth2/AuthenticationOAuth2.java 87.50% <ø> (+5.68%) ⬆️
... and 15 more

... and 1070 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@liangyepianzhou liangyepianzhou merged commit 671994f into apache:master Jul 2, 2025
166 of 173 checks passed
BewareMyPower pushed a commit that referenced this pull request Jul 17, 2025
…s.lang3 (#24473)

### Background
  import change: org.apache.commons.lang to org.apache.commons.lang3

### Modifications

1. import change: org.apache.commons.lang to org.apache.commons.lang3
2. add check style rules that prevent using commons-lang for new code.

(cherry picked from commit 671994f)
lhotari pushed a commit that referenced this pull request Jul 17, 2025
…s.lang3 (#24473)

  import change: org.apache.commons.lang to org.apache.commons.lang3

1. import change: org.apache.commons.lang to org.apache.commons.lang3
2. add check style rules that prevent using commons-lang for new code.

(cherry picked from commit 671994f)
priyanshu-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 22, 2025
…s.lang3 (apache#24473)

### Background
  import change: org.apache.commons.lang to org.apache.commons.lang3

### Modifications

1. import change: org.apache.commons.lang to org.apache.commons.lang3
2. add check style rules that prevent using commons-lang for new code.

(cherry picked from commit 671994f)
(cherry picked from commit 2107ff0)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 24, 2025
…s.lang3 (apache#24473)

### Background
  import change: org.apache.commons.lang to org.apache.commons.lang3

### Modifications

1. import change: org.apache.commons.lang to org.apache.commons.lang3
2. add check style rules that prevent using commons-lang for new code.

(cherry picked from commit 671994f)
(cherry picked from commit 2107ff0)
@lhotari
Copy link
Member

lhotari commented Jul 25, 2025

Cherry-picking to branch-3.0 since commons-lang hasn't been maintained for a long time and there's a minor security issue with commons-lang that is fixed in commons-lang3:3.18.0, CVE-2025-48924

lhotari pushed a commit to lhotari/pulsar that referenced this pull request Jul 25, 2025
…s.lang3 (apache#24473)

  import change: org.apache.commons.lang to org.apache.commons.lang3

1. import change: org.apache.commons.lang to org.apache.commons.lang3
2. add check style rules that prevent using commons-lang for new code.

(cherry picked from commit 671994f)
nodece pushed a commit to ascentstream/pulsar that referenced this pull request Jul 28, 2025
…s.lang3 (apache#24473)

  import change: org.apache.commons.lang to org.apache.commons.lang3

1. import change: org.apache.commons.lang to org.apache.commons.lang3
2. add check style rules that prevent using commons-lang for new code.

(cherry picked from commit 671994f)
nodece pushed a commit to ascentstream/pulsar that referenced this pull request Jul 28, 2025
…s.lang3 (apache#24473)

  import change: org.apache.commons.lang to org.apache.commons.lang3

1. import change: org.apache.commons.lang to org.apache.commons.lang3
2. add check style rules that prevent using commons-lang for new code.

(cherry picked from commit 671994f)
priyanshu-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 28, 2025
…s.lang3 (apache#24473)

  import change: org.apache.commons.lang to org.apache.commons.lang3

1. import change: org.apache.commons.lang to org.apache.commons.lang3
2. add check style rules that prevent using commons-lang for new code.

(cherry picked from commit 671994f)
(cherry picked from commit dec94b9)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 31, 2025
…s.lang3 (apache#24473)

  import change: org.apache.commons.lang to org.apache.commons.lang3

1. import change: org.apache.commons.lang to org.apache.commons.lang3
2. add check style rules that prevent using commons-lang for new code.

(cherry picked from commit 671994f)
(cherry picked from commit dec94b9)
KannarFr pushed a commit to CleverCloud/pulsar that referenced this pull request Sep 22, 2025
…s.lang3 (apache#24473)

### Background
  import change: org.apache.commons.lang to org.apache.commons.lang3

### Modifications

1. import change: org.apache.commons.lang to org.apache.commons.lang3
2. add check style rules that prevent using commons-lang for new code.
walkinggo pushed a commit to walkinggo/pulsar that referenced this pull request Oct 8, 2025
…s.lang3 (apache#24473)

### Background
  import change: org.apache.commons.lang to org.apache.commons.lang3

### Modifications

1. import change: org.apache.commons.lang to org.apache.commons.lang3
2. add check style rules that prevent using commons-lang for new code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants