[improve][broker] change to warn log level for ack validation error #24459

RobertIndie · 2025-06-25T03:40:53Z

Motivation

The error log

pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java

Lines 757 to 758 in e7eb7b3

    
           log.error("[{}] [{}] Received ack for corrupted message at {} - Reason: {}", subscription, 
        
                   consumerId, position, ack.getValidationError());

mostly comes from the client.

The client could already receive this error, as seen at

pulsar/pulsar-common/src/main/java/org/apache/pulsar/common/api/raw/MessageParser.java

Lines 151 to 152 in 82237d3

    
           log.error("[{}] Failed to decompress message with {} at {}:{} : {}", topic, 
        
                   msgMetadata.getCompression(), ledgerId, entryId, e.getMessage(), e);

We do not need to print this error log in the broker. Doing so would fill up the broker error logs and make them hard to manage.

Modification

Change to warn log level for ack validation error

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

Documentation

doc
doc-required
doc-not-needed
doc-complete

Matching PR in forked repository

PR in forked repository:

## Motivation The error log https://github.com/apache/pulsar/blob/e7eb7b37a779f9b74b8abf43cf622957663495d1/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java#L757-L758 mostly comes from the client. The client could already receive this error, as seen at https://github.com/apache/pulsar/blob/82237d3684fe506bcb6426b3b23f413422e6e4fb/pulsar-common/src/main/java/org/apache/pulsar/common/api/raw/MessageParser.java#L151-L152 We do not need to print this error log in the broker. Doing so would fill up the broker error logs and make them hard to manage. ## Modification - Change to warn log level for ack validation error

github-actions · 2025-06-25T03:41:19Z

@RobertIndie Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

codecov-commenter · 2025-06-25T10:20:28Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.25%. Comparing base (bbc6224) to head (66d4590).
Report is 1167 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #24459      +/-   ##
============================================
+ Coverage     73.57%   74.25%   +0.67%     
+ Complexity    32624    32359     -265     
============================================
  Files          1877     1868       -9     
  Lines        139502   145502    +6000     
  Branches      15299    16643    +1344     
============================================
+ Hits         102638   108037    +5399     
+ Misses        28908    28900       -8     
- Partials       7956     8565     +609

Flag	Coverage Δ
inttests	`26.78% <0.00%> (+2.20%)`	⬆️
systests	`23.37% <0.00%> (-0.95%)`	⬇️
unittests	`73.73% <100.00%> (+0.88%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ava/org/apache/pulsar/broker/service/Consumer.java	`85.20% <100.00%> (-1.46%)`	⬇️

... and 1086 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…24459) ## Motivation The error log https://github.com/apache/pulsar/blob/e7eb7b37a779f9b74b8abf43cf622957663495d1/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java#L757-L758 mostly comes from the client. The client could already receive this error, as seen at https://github.com/apache/pulsar/blob/82237d3684fe506bcb6426b3b23f413422e6e4fb/pulsar-common/src/main/java/org/apache/pulsar/common/api/raw/MessageParser.java#L151-L152 We do not need to print this error log in the broker. Doing so would fill up the broker error logs and make them hard to manage. ## Modification - Change to warn log level for ack validation error (cherry picked from commit 3f9e21a)

…pache#24459) ## Motivation The error log https://github.com/apache/pulsar/blob/e7eb7b37a779f9b74b8abf43cf622957663495d1/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java#L757-L758 mostly comes from the client. The client could already receive this error, as seen at https://github.com/apache/pulsar/blob/82237d3684fe506bcb6426b3b23f413422e6e4fb/pulsar-common/src/main/java/org/apache/pulsar/common/api/raw/MessageParser.java#L151-L152 We do not need to print this error log in the broker. Doing so would fill up the broker error logs and make them hard to manage. ## Modification - Change to warn log level for ack validation error (cherry picked from commit 3f9e21a) (cherry picked from commit 949a593)

…24459) ## Motivation The error log https://github.com/apache/pulsar/blob/e7eb7b37a779f9b74b8abf43cf622957663495d1/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java#L757-L758 mostly comes from the client. The client could already receive this error, as seen at https://github.com/apache/pulsar/blob/82237d3684fe506bcb6426b3b23f413422e6e4fb/pulsar-common/src/main/java/org/apache/pulsar/common/api/raw/MessageParser.java#L151-L152 We do not need to print this error log in the broker. Doing so would fill up the broker error logs and make them hard to manage. ## Modification - Change to warn log level for ack validation error (cherry picked from commit 3f9e21a)

…pache#24459) ## Motivation The error log https://github.com/apache/pulsar/blob/e7eb7b37a779f9b74b8abf43cf622957663495d1/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java#L757-L758 mostly comes from the client. The client could already receive this error, as seen at https://github.com/apache/pulsar/blob/82237d3684fe506bcb6426b3b23f413422e6e4fb/pulsar-common/src/main/java/org/apache/pulsar/common/api/raw/MessageParser.java#L151-L152 We do not need to print this error log in the broker. Doing so would fill up the broker error logs and make them hard to manage. ## Modification - Change to warn log level for ack validation error (cherry picked from commit 3f9e21a) (cherry picked from commit f67f3bf)

…pache#24459) ## Motivation The error log https://github.com/apache/pulsar/blob/e7eb7b37a779f9b74b8abf43cf622957663495d1/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java#L757-L758 mostly comes from the client. The client could already receive this error, as seen at https://github.com/apache/pulsar/blob/82237d3684fe506bcb6426b3b23f413422e6e4fb/pulsar-common/src/main/java/org/apache/pulsar/common/api/raw/MessageParser.java#L151-L152 We do not need to print this error log in the broker. Doing so would fill up the broker error logs and make them hard to manage. ## Modification - Change to warn log level for ack validation error (cherry picked from commit 3f9e21a)

…pache#24459) ## Motivation The error log https://github.com/apache/pulsar/blob/e7eb7b37a779f9b74b8abf43cf622957663495d1/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java#L757-L758 mostly comes from the client. The client could already receive this error, as seen at https://github.com/apache/pulsar/blob/82237d3684fe506bcb6426b3b23f413422e6e4fb/pulsar-common/src/main/java/org/apache/pulsar/common/api/raw/MessageParser.java#L151-L152 We do not need to print this error log in the broker. Doing so would fill up the broker error logs and make them hard to manage. ## Modification - Change to warn log level for ack validation error

RobertIndie self-assigned this Jun 25, 2025

RobertIndie added ready-to-test release/3.0.13 release/4.0.6 labels Jun 25, 2025

github-actions bot added the doc-label-missing label Jun 25, 2025

RobertIndie added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Jun 25, 2025

BewareMyPower approved these changes Jun 25, 2025

View reviewed changes

dao-jun approved these changes Jun 25, 2025

View reviewed changes

RobertIndie merged commit 3f9e21a into apache:master Jun 25, 2025
198 of 206 checks passed

BewareMyPower added the cherry-picked/branch-3.0 label Jun 27, 2025

RobertIndie added the cherry-picked/branch-4.0 label Jul 1, 2025

RobertIndie added cherry-picked/branch-3.3 release/3.3.8 labels Jul 1, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[improve][broker] change to warn log level for ack validation error #24459

[improve][broker] change to warn log level for ack validation error #24459

RobertIndie commented Jun 25, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 25, 2025

Uh oh!

codecov-commenter commented Jun 25, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	log.error("[{}] [{}] Received ack for corrupted message at {} - Reason: {}", subscription,
	consumerId, position, ack.getValidationError());

	log.error("[{}] Failed to decompress message with {} at {}:{} : {}", topic,
	msgMetadata.getCompression(), ledgerId, entryId, e.getMessage(), e);

[improve][broker] change to warn log level for ack validation error #24459

[improve][broker] change to warn log level for ack validation error #24459

Conversation

RobertIndie commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Modification

Does this pull request potentially affect one of the following parts:

Documentation

Matching PR in forked repository

Uh oh!

github-actions bot commented Jun 25, 2025

Uh oh!

codecov-commenter commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

RobertIndie commented Jun 25, 2025 •

edited

Loading

codecov-commenter commented Jun 25, 2025 •

edited

Loading