[fix][broker] Fix REST API to produce messages to single-partitioned topics #24450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
approved these changes
Jun 26, 2025
BewareMyPower
approved these changes
Jun 26, 2025
nodece
approved these changes
Jun 26, 2025
Contributor
Author
|
I am doing pulsarbot run-failure-checks |
…topics, add annotation for rerun CI
Contributor
Author
The tests for BROKER_GROUP_2 were successfully executed using the command: |
nodece
approved these changes
Jun 30, 2025
codelipenghui
approved these changes
Jul 30, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24450 +/- ##
============================================
+ Coverage 73.57% 75.94% +2.36%
- Complexity 32624 36257 +3633
============================================
Files 1877 1882 +5
Lines 139502 159994 +20492
Branches 15299 20103 +4804
============================================
+ Hits 102638 121504 +18866
- Misses 28908 29516 +608
- Partials 7956 8974 +1018
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Aug 6, 2025
…topics (apache#24450) (cherry picked from commit fa28d1c)
gaozhangmin
pushed a commit
to gaozhangmin/pulsar
that referenced
this pull request
Aug 13, 2025
poorbarcode
pushed a commit
to poorbarcode/pulsar
that referenced
this pull request
Aug 14, 2025
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 20, 2025
…topics (apache#24450) (cherry picked from commit fa28d1c) (cherry picked from commit da9ed2b)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 20, 2025
…topics (apache#24450) (cherry picked from commit fa28d1c) (cherry picked from commit da9ed2b)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 20, 2025
…topics (apache#24450) (cherry picked from commit fa28d1c) (cherry picked from commit 57e48d1)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 26, 2025
…topics (apache#24450) (cherry picked from commit fa28d1c) (cherry picked from commit 57e48d1)
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24442
Motivation
The REST API fails to produce messages to single-partitioned topics (partition count = 1) due to incorrect topic type detection.
Modifications
TopicsBaseto properly handle single-partitioned topicsif (!topicName.isPartitioned() && metadata.partitions > 1)to
if (!topicName.isPartitioned() && metadata.partitions > 0)Verifying this change
This change added tests and can be verified as follows:
TopicsTest.testProduceToPartitionedTopictest cases with single-partition topic testing.Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: Joforde@408ac9d