[refactor][broker] Expose the managedLedger field for the sub class #24448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- ### Motivation When do some expirmental changes with the managed ledger, we need to access the lock fields in the sub-class. Change the field scope to allow this happen.
dao-jun
approved these changes
Jun 24, 2025
hangc0276
approved these changes
Jun 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24448 +/- ##
============================================
+ Coverage 73.57% 74.31% +0.74%
- Complexity 32624 32752 +128
============================================
Files 1877 1868 -9
Lines 139502 145501 +5999
Branches 15299 16643 +1344
============================================
+ Hits 102638 108130 +5492
+ Misses 28908 28806 -102
- Partials 7956 8565 +609
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
15 tasks
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 27, 2025
…pache#24448) (cherry picked from commit 7cd9410) (cherry picked from commit e41ae8c)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 30, 2025
…pache#24448) (cherry picked from commit 7cd9410) (cherry picked from commit e41ae8c)
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When do some expirmental changes with the managed ledger, we need to access the lock fields in the sub-class. Change the field scope to allow this happen.
Fixes #xyz
Main Issue: #xyz
PIP: #xyz
Motivation
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: