[improve][pip] PIP-427: Align pulsar-admin Default for Mark-Delete Rate with Broker Configuration #24425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te with Broker Configuration
poorbarcode
approved these changes
Jun 18, 2025
lhotari
approved these changes
Jun 18, 2025
coderzc
approved these changes
Jun 18, 2025
shibd
approved these changes
Jun 18, 2025
14 tasks
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
…te with Broker Configuration (apache#24425)
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
…te with Broker Configuration (apache#24425)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the pulsar-admin namespaces set-persistence command implicitly resets the mark-delete rate to 0 (unlimited) if the --ml-mark-delete-max-rate flag is omitted when changing other policies. This behavior can cause unexpected high load on BookKeeper and acts as a "footgun" for operators.
This PR added the PIP by making the default behavior safer and more intuitive, aligning it with the broker's own configuration.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: