Skip to content

Conversation

@poorbarcode
Copy link
Contributor

Motivation

Reproduce steps

  • Create a remote cluster with an incorrect auth-param.
  • Call pulsar-admin topics set-replication-clusters <clusters> <topic>, which will trigger the creation of an Internal PulsarAdmin Object in the broker's memory.
  • Remove the cluster that contains incorrect auth-params
  • Recreate the cluster with the correct info
  • Issue: the broker still maintains a PulsarAdmin with an incorrect auth-params that we set the first time

Modifications

  • Close and remove the PulsarAdmin Object of the remote cluster when removing clusters

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: x

…maintains the incorrect cluster configuration even if you removed it
@poorbarcode poorbarcode added this to the 4.1.0 milestone Jun 17, 2025
@poorbarcode poorbarcode self-assigned this Jun 17, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 17, 2025
@codelipenghui
Copy link
Contributor

/pulsarbot run-failure-checks

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.17%. Comparing base (bbc6224) to head (4debeec).
⚠️ Report is 1311 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24419      +/-   ##
============================================
+ Coverage     73.57%   74.17%   +0.60%     
+ Complexity    32624    32293     -331     
============================================
  Files          1877     1868       -9     
  Lines        139502   145371    +5869     
  Branches      15299    16630    +1331     
============================================
+ Hits         102638   107833    +5195     
- Misses        28908    28988      +80     
- Partials       7956     8550     +594     
Flag Coverage Δ
inttests 26.63% <0.00%> (+2.04%) ⬆️
systests 23.29% <0.00%> (-1.04%) ⬇️
unittests 73.67% <100.00%> (+0.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rg/apache/pulsar/broker/service/BrokerService.java 83.72% <100.00%> (+2.94%) ⬆️

... and 1086 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@poorbarcode poorbarcode merged commit e157cac into apache:master Jun 17, 2025
149 of 155 checks passed
lhotari pushed a commit that referenced this pull request Jun 19, 2025
…maintains the incorrect cluster configuration even if you removed it (#24419)

(cherry picked from commit e157cac)
lhotari pushed a commit that referenced this pull request Jun 19, 2025
…maintains the incorrect cluster configuration even if you removed it (#24419)

(cherry picked from commit e157cac)
lhotari pushed a commit that referenced this pull request Jun 19, 2025
…maintains the incorrect cluster configuration even if you removed it (#24419)

(cherry picked from commit e157cac)
nodece pushed a commit to nodece/pulsar that referenced this pull request Jun 20, 2025
…maintains the incorrect cluster configuration even if you removed it (apache#24419)

(cherry picked from commit e157cac)
ganesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 20, 2025
…maintains the incorrect cluster configuration even if you removed it (apache#24419)

(cherry picked from commit e157cac)
(cherry picked from commit 1bb4439)
ganesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 21, 2025
…maintains the incorrect cluster configuration even if you removed it (apache#24419)

(cherry picked from commit e157cac)
(cherry picked from commit 67e6238)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 24, 2025
…maintains the incorrect cluster configuration even if you removed it (apache#24419)

(cherry picked from commit e157cac)
(cherry picked from commit 67e6238)
ganesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 27, 2025
…maintains the incorrect cluster configuration even if you removed it (apache#24419)

(cherry picked from commit e157cac)
(cherry picked from commit 1bb4439)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 30, 2025
…maintains the incorrect cluster configuration even if you removed it (apache#24419)

(cherry picked from commit e157cac)
(cherry picked from commit 1bb4439)
KannarFr pushed a commit to CleverCloud/pulsar that referenced this pull request Sep 22, 2025
…maintains the incorrect cluster configuration even if you removed it (apache#24419)
walkinggo pushed a commit to walkinggo/pulsar that referenced this pull request Oct 8, 2025
…maintains the incorrect cluster configuration even if you removed it (apache#24419)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants