[fix][broker] Fix the wrong cache name #24407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
Contributor
codelipenghui
left a comment
There was a problem hiding this comment.
@Technoboy- Is it possible to add a test for verifying the final metrics labels value?
merlimat
approved these changes
Jun 13, 2025
codelipenghui
approved these changes
Jun 13, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24407 +/- ##
============================================
+ Coverage 73.57% 74.30% +0.72%
+ Complexity 32624 32341 -283
============================================
Files 1877 1868 -9
Lines 139502 145364 +5862
Branches 15299 16629 +1330
============================================
+ Hits 102638 108006 +5368
+ Misses 28908 28820 -88
- Partials 7956 8538 +582
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dao-jun
approved these changes
Jun 13, 2025
lhotari
pushed a commit
that referenced
this pull request
Jun 19, 2025
(cherry picked from commit 91e0bf2)
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It's a follow up fix for #24365. we need to call
recordStatsto gather statistics and filter non-zero statistics. And also fix the wrong cache name.Documentation
docdoc-requireddoc-not-neededdoc-complete