-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][ml] Cursor ignores the position that has an empty ack-set if disabled deletionAtBatchIndexLevelEnabled #24406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sabled deletionAtBatchIndexLevelEnabled
4 tasks
nodece
approved these changes
Jun 13, 2025
codelipenghui
approved these changes
Jun 13, 2025
dao-jun
approved these changes
Jun 13, 2025
Member
|
@poorbarcode What Pulsar versions are impacted by this bug? In other words, when did we introduce this regression? |
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Jun 20, 2025
…sabled deletionAtBatchIndexLevelEnabled (apache#24406) (cherry picked from commit 3bd70fd)
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 20, 2025
…sabled deletionAtBatchIndexLevelEnabled (apache#24406) (cherry picked from commit 3bd70fd) (cherry picked from commit e10fce8)
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 21, 2025
…sabled deletionAtBatchIndexLevelEnabled (apache#24406) (cherry picked from commit 3bd70fd) (cherry picked from commit 9883d92)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 24, 2025
…sabled deletionAtBatchIndexLevelEnabled (apache#24406) (cherry picked from commit 3bd70fd) (cherry picked from commit 9883d92)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 30, 2025
…sabled deletionAtBatchIndexLevelEnabled (apache#24406) (cherry picked from commit 3bd70fd) (cherry picked from commit e10fce8)
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
…sabled deletionAtBatchIndexLevelEnabled (apache#24406)
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
…sabled deletionAtBatchIndexLevelEnabled (apache#24406)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.13
release/3.3.8
release/4.0.6
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After disabling
deletionAtBatchIndexLevelEnabled,ManagedCursorImplignores positions that have an emptyackSetwhen callingcursor.delete, which leads to the caller acknowledging nothing.And the Transaction task will acknowledge positions that have an empty
ackSetafter all single messages of a batch were acknowledged,Modifications
Fix the bug
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x