Skip to content

[improve][admin] PIP-422 part 1: Support global topic-level replicated clusters policy #24390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
poorbarcode merged 10 commits into from
Aug 4, 2025
Merged

[improve][admin] PIP-422 part 1: Support global topic-level replicated clusters policy #24390

poorbarcode merged 10 commits into from
Aug 4, 2025

Conversation

@poorbarcode
Copy link
Contributor

@poorbarcode poorbarcode commented Jun 6, 2025 •
edited
Loading

Motivation

See the PIP-422

Modifications

  • Support global topic-level replicated clusters policy
  • Delete local topic-level policies after removing the local cluster from the global topic-level replicated clusters policy.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: x

@poorbarcode poorbarcode added this to the 4.1.0 milestone Jun 6, 2025
@poorbarcode poorbarcode self-assigned this Jun 6, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 6, 2025
@poorbarcode poorbarcode force-pushed the fix/global_policies_deleting_2 branch 2 times, most recently from f523365 to 2dcb982 Compare June 30, 2025 07:30
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 75.70093% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.37%. Comparing base (fa28d1c) to head (9e040af).

Files with missing lines Patch % Lines
.../org/apache/pulsar/admin/cli/CmdTopicPolicies.java 50.00% 10 Missing ⚠️
...pulsar/broker/admin/impl/PersistentTopicsBase.java 71.42% 2 Missing and 4 partials ⚠️
...pache/pulsar/broker/admin/v2/PersistentTopics.java 80.00% 1 Missing and 4 partials ⚠️
...sar/broker/service/persistent/PersistentTopic.java 82.35% 2 Missing and 1 partial ⚠️
.../service/SystemTopicBasedTopicPoliciesService.java 88.88% 1 Missing ⚠️
...he/pulsar/broker/service/TopicPoliciesService.java 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24390      +/-   ##
============================================
+ Coverage     74.30%   74.37%   +0.07%     
- Complexity    32671    33081     +410     
============================================
  Files          1880     1880              
  Lines        146433   146518      +85     
  Branches      16789    16798       +9     
============================================
+ Hits         108807   108975     +168     
+ Misses        28986    28888      -98     
- Partials       8640     8655      +15
Flag Coverage Δ
inttests 26.70% <7.47%> (-0.03%) ⬇️
systests 23.38% <6.54%> (+<0.01%) ⬆️
unittests 73.83% <75.70%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../org/apache/pulsar/client/admin/TopicPolicies.java 100.00% <ø> (ø)
...ulsar/client/admin/internal/TopicPoliciesImpl.java 96.07% <100.00%> (+0.10%) ⬆️
.../service/SystemTopicBasedTopicPoliciesService.java 76.11% <88.88%> (-0.77%) ⬇️
...he/pulsar/broker/service/TopicPoliciesService.java 83.33% <50.00%> (-2.39%) ⬇️
...sar/broker/service/persistent/PersistentTopic.java 80.17% <82.35%> (-0.29%) ⬇️
...pache/pulsar/broker/admin/v2/PersistentTopics.java 88.38% <80.00%> (-0.05%) ⬇️
...pulsar/broker/admin/impl/PersistentTopicsBase.java 69.98% <71.42%> (+0.05%) ⬆️
.../org/apache/pulsar/admin/cli/CmdTopicPolicies.java 88.70% <50.00%> (-1.19%) ⬇️

... and 73 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@poorbarcode poorbarcode force-pushed the fix/global_policies_deleting_2 branch from b8d59be to 8d6078d Compare July 14, 2025 01:59
@poorbarcode poorbarcode force-pushed the fix/global_policies_deleting_2 branch from 8c3547c to 4a7003d Compare July 30, 2025 08:50
@poorbarcode poorbarcode requested a review from Technoboy- July 30, 2025 08:55
@poorbarcode poorbarcode force-pushed the fix/global_policies_deleting_2 branch from 31ff3b5 to 9e040af Compare August 1, 2025 09:58
@poorbarcode poorbarcode merged commit 1e57827 into apache:master Aug 4, 2025
51 checks passed
@lhotari
Copy link
Member

lhotari commented Aug 4, 2025

@poorbarcode Removing maintenance branch release flags until there's been a discussion on dev mailing list that it's ok to backport to maintenance releases.

gaozhangmin pushed a commit to gaozhangmin/pulsar that referenced this pull request Aug 13, 2025
@poorbarcode
[improve][admin] PIP-422 part 1: Support global topic-level replicate…
94a6758 
…d clusters policy (apache#24390)
poorbarcode added a commit to poorbarcode/pulsar that referenced this pull request Aug 14, 2025
@poorbarcode
[improve][admin] PIP-422 part 1: Support global topic-level replicate…
c70f104 
…d clusters policy (apache#24390)
poorbarcode added a commit that referenced this pull request Aug 20, 2025
@poorbarcode
[improve][admin] PIP-422 part 1: Support global topic-level replicate…
cb50e3f 
…d clusters policy (#24390)

(cherry picked from commit 1e57827)
@poorbarcode
Copy link
Contributor Author

poorbarcode commented Aug 20, 2025

Cherry-picked into branch-4.0

manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Aug 21, 2025
@poorbarcode @manas-ctds
[improve][admin] PIP-422 part 1: Support global topic-level replicate…
ac16368 
…d clusters policy (apache#24390)

(cherry picked from commit 1e57827)
(cherry picked from commit cb50e3f)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Aug 28, 2025
@poorbarcode @manas-ctds
[improve][admin] PIP-422 part 1: Support global topic-level replicate…
1313923 
…d clusters policy (apache#24390)

(cherry picked from commit 1e57827)
(cherry picked from commit cb50e3f)
Technoboy- pushed a commit to Technoboy-/pulsar that referenced this pull request Sep 10, 2025
@poorbarcode @Technoboy-
[improve][admin] PIP-422 part 1: Support global topic-level replicate…
b403dd8 
…d clusters policy (apache#24390)

(cherry picked from commit 1e57827)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Sep 12, 2025
@poorbarcode @srinath-ctds
[improve][admin] PIP-422 part 1: Support global topic-level replicate…
dacbc3a 
…d clusters policy (apache#24390)

(cherry picked from commit 1e57827)
(cherry picked from commit cb50e3f)
KannarFr pushed a commit to CleverCloud/pulsar that referenced this pull request Sep 22, 2025
@poorbarcode @KannarFr
[improve][admin] PIP-422 part 1: Support global topic-level replicate…
1c84bd9 
…d clusters policy (apache#24390)
walkinggo pushed a commit to walkinggo/pulsar that referenced this pull request Oct 8, 2025
@poorbarcode @walkinggo
[improve][admin] PIP-422 part 1: Support global topic-level replicate…
7b1fbe3 
…d clusters policy (apache#24390)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

Assignees

@poorbarcode poorbarcode

Labels

cherry-picked/branch-4.0 doc-not-needed Your PR changes do not impact docs ready-to-test release/4.0.7 type/PIP

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@poorbarcode @codecov-commenter @lhotari @Technoboy- @coderzc