Skip to content

[fix][broker] expose consumer name for partitioned topic stats #24360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lhotari merged 3 commits into from
Jun 1, 2025
Merged

[fix][broker] expose consumer name for partitioned topic stats #24360

lhotari merged 3 commits into from
Jun 1, 2025

Conversation

@mattisonchao
Copy link
Member

@mattisonchao mattisonchao commented May 29, 2025 •
edited
Loading

Motivation

Expose the consumer name for partitioned topic stats

Modifications

  • Add consumerName for ConsumerStatsImpl

Verifying this change

  • Make sure that the change passes the CI checks.

  • doc-not-needed

@mattisonchao mattisonchao self-assigned this May 29, 2025
@github-actions
Copy link

github-actions bot commented May 29, 2025

@mattisonchao Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels May 29, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.16%. Comparing base (bbc6224) to head (521eaee).
⚠️ Report is 1253 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24360      +/-   ##
============================================
+ Coverage     73.57%   74.16%   +0.58%     
+ Complexity    32624    32615       -9     
============================================
  Files          1877     1866      -11     
  Lines        139502   145147    +5645     
  Branches      15299    16596    +1297     
============================================
+ Hits         102638   107644    +5006     
- Misses        28908    28951      +43     
- Partials       7956     8552     +596
Flag Coverage Δ
inttests 26.87% <0.00%> (+2.28%) ⬆️
systests 23.30% <0.00%> (-1.02%) ⬇️
unittests 73.65% <100.00%> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../common/policies/data/stats/ConsumerStatsImpl.java 100.00% <100.00%> (+2.38%) ⬆️

... and 1084 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lhotari
lhotari approved these changes Jun 1, 2025
View reviewed changes
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari added this to the 4.1.0 milestone Jun 1, 2025
@lhotari lhotari merged commit 1c30871 into apache:master Jun 1, 2025
56 of 57 checks passed
lhotari pushed a commit that referenced this pull request Jun 2, 2025
@mattisonchao @lhotari
[fix][broker] expose consumer name for partitioned topic stats (#24360)
4062955 
(cherry picked from commit 1c30871)
lhotari pushed a commit that referenced this pull request Jun 2, 2025
@mattisonchao @lhotari
[fix][broker] expose consumer name for partitioned topic stats (#24360)
c9d23a0 
(cherry picked from commit 1c30871)
lhotari pushed a commit that referenced this pull request Jun 2, 2025
@mattisonchao @lhotari
[fix][broker] expose consumer name for partitioned topic stats (#24360)
a858683 
(cherry picked from commit 1c30871)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 4, 2025
@mattisonchao @ganesh-ctds
[fix][broker] expose consumer name for partitioned topic stats (apach…
aad9f3b 
…e#24360)

(cherry picked from commit 1c30871)
(cherry picked from commit c9d23a0)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 4, 2025
@mattisonchao @manas-ctds
[fix][broker] expose consumer name for partitioned topic stats (apach…
48f0a62 
…e#24360)

(cherry picked from commit 1c30871)
(cherry picked from commit 4062955)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 4, 2025
@mattisonchao @ganesh-ctds
[fix][broker] expose consumer name for partitioned topic stats (apach…
58d960c 
…e#24360)

(cherry picked from commit 1c30871)
(cherry picked from commit c9d23a0)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 4, 2025
@mattisonchao @ganesh-ctds
[fix][broker] expose consumer name for partitioned topic stats (apach…
ea965b6 
…e#24360)

(cherry picked from commit 1c30871)
(cherry picked from commit c9d23a0)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 5, 2025
@mattisonchao @srinath-ctds
[fix][broker] expose consumer name for partitioned topic stats (apach…
e1cfe3f 
…e#24360)

(cherry picked from commit 1c30871)
(cherry picked from commit 4062955)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 5, 2025
@mattisonchao @ganesh-ctds
[fix][broker] expose consumer name for partitioned topic stats (apach…
6f3207c 
…e#24360)

(cherry picked from commit 1c30871)
(cherry picked from commit c9d23a0)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 6, 2025
@mattisonchao @ganesh-ctds
[fix][broker] expose consumer name for partitioned topic stats (apach…
268054f 
…e#24360)

(cherry picked from commit 1c30871)
(cherry picked from commit c9d23a0)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 10, 2025
@mattisonchao @srinath-ctds
[fix][broker] expose consumer name for partitioned topic stats (apach…
9a61ae5 
…e#24360)

(cherry picked from commit 1c30871)
(cherry picked from commit c9d23a0)
nodece pushed a commit to nodece/pulsar that referenced this pull request Jun 18, 2025
@mattisonchao @nodece
[fix][broker] expose consumer name for partitioned topic stats (apach…
9512fbb 
…e#24360)

(cherry picked from commit 1c30871)
KannarFr pushed a commit to CleverCloud/pulsar that referenced this pull request Sep 22, 2025
@mattisonchao @KannarFr
[fix][broker] expose consumer name for partitioned topic stats (apach…
1ffe0d7 
…e#24360)
walkinggo pushed a commit to walkinggo/pulsar that referenced this pull request Oct 8, 2025
@mattisonchao @walkinggo
[fix][broker] expose consumer name for partitioned topic stats (apach…
d6f2b32 
…e#24360)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhotari lhotari lhotari approved these changes

Assignees

@mattisonchao mattisonchao

Labels

cherry-picked/branch-3.0 cherry-picked/branch-3.3 cherry-picked/branch-4.0 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.13 release/3.3.8 release/4.0.6

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mattisonchao @codecov-commenter @lhotari