Skip to content

[fix][io] Acknowledge RabbitMQ message after processing the message successfully #24354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
david-streamlio merged 2 commits into from
May 28, 2025
Merged

[fix][io] Acknowledge RabbitMQ message after processing the message successfully #24354

david-streamlio merged 2 commits into from
May 28, 2025

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented May 27, 2025 •
edited
Loading

Fixes #24353

Motivation

See #24346

Modifications

  • add ackFunction and failFunction to the internal RabbitMQRecord class and use these functions in the ack and fail implementations of the Record interface.

  • switch to use individual acks towards RabbitMQ since there's no benefit of using "multi" acks when every message will get acked in any case

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari
[fix][io] Delay acknowledging RabbitMQ message until the processing i…
4d86ae8 
…n the source connector has completed successfully
@lhotari lhotari added this to the 4.1.0 milestone May 27, 2025
@lhotari lhotari requested a review from merlimat May 27, 2025 21:29
@lhotari lhotari self-assigned this May 27, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 27, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 74.25%. Comparing base (bbc6224) to head (9443e02).
Report is 1123 commits behind head on master.

Files with missing lines Patch % Lines
.../org/apache/pulsar/io/rabbitmq/RabbitMQSource.java 0.00% 15 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24354      +/-   ##
============================================
+ Coverage     73.57%   74.25%   +0.68%     
+ Complexity    32624     2405   -30219     
============================================
  Files          1877     1866      -11     
  Lines        139502   145140    +5638     
  Branches      15299    16595    +1296     
============================================
+ Hits         102638   107779    +5141     
+ Misses        28908    28834      -74     
- Partials       7956     8527     +571
Flag Coverage Δ
inttests 26.71% <ø> (+2.12%) ⬆️
systests 23.32% <0.00%> (-1.01%) ⬇️
unittests 73.75% <0.00%> (+0.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../org/apache/pulsar/io/rabbitmq/RabbitMQSource.java 57.77% <0.00%> (-16.51%) ⬇️

... and 1085 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari lhotari requested a review from david-streamlio May 28, 2025 06:11
@lhotari lhotari force-pushed the lh-rabbitmq-source-at-least-once branch from 6c1b525 to 9443e02 Compare May 28, 2025 06:32
david-streamlio
david-streamlio approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@david-streamlio david-streamlio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david-streamlio david-streamlio merged commit 76c6f6a into apache:master May 28, 2025
55 checks passed
lhotari added a commit that referenced this pull request Jun 2, 2025
@lhotari
[fix][io] Acknowledge RabbitMQ message after processing the message s…
c470b6d 
…uccessfully (#24354)

(cherry picked from commit 76c6f6a)
lhotari added a commit that referenced this pull request Jun 2, 2025
@lhotari
[fix][io] Acknowledge RabbitMQ message after processing the message s…
43c9399 
…uccessfully (#24354)

(cherry picked from commit 76c6f6a)
lhotari added a commit that referenced this pull request Jun 2, 2025
@lhotari
[fix][io] Acknowledge RabbitMQ message after processing the message s…
f03d8d9 
…uccessfully (#24354)

(cherry picked from commit 76c6f6a)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 4, 2025
@lhotari @ganesh-ctds
[fix][io] Acknowledge RabbitMQ message after processing the message s…
e1a6139 
…uccessfully (apache#24354)

(cherry picked from commit 76c6f6a)
(cherry picked from commit 43c9399)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 4, 2025
@lhotari @manas-ctds
[fix][io] Acknowledge RabbitMQ message after processing the message s…
28828da 
…uccessfully (apache#24354)

(cherry picked from commit 76c6f6a)
(cherry picked from commit c470b6d)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 4, 2025
@lhotari @ganesh-ctds
[fix][io] Acknowledge RabbitMQ message after processing the message s…
1cd85fa 
…uccessfully (apache#24354)

(cherry picked from commit 76c6f6a)
(cherry picked from commit 43c9399)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 4, 2025
@lhotari @ganesh-ctds
[fix][io] Acknowledge RabbitMQ message after processing the message s…
d3ffe40 
…uccessfully (apache#24354)

(cherry picked from commit 76c6f6a)
(cherry picked from commit 43c9399)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 5, 2025
@lhotari @srinath-ctds
[fix][io] Acknowledge RabbitMQ message after processing the message s…
89bdc31 
…uccessfully (apache#24354)

(cherry picked from commit 76c6f6a)
(cherry picked from commit c470b6d)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 5, 2025
@lhotari @ganesh-ctds
[fix][io] Acknowledge RabbitMQ message after processing the message s…
d29ba2e 
…uccessfully (apache#24354)

(cherry picked from commit 76c6f6a)
(cherry picked from commit 43c9399)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 10, 2025
@lhotari @srinath-ctds
[fix][io] Acknowledge RabbitMQ message after processing the message s…
33f615f 
…uccessfully (apache#24354)

(cherry picked from commit 76c6f6a)
(cherry picked from commit 43c9399)
nodece pushed a commit to nodece/pulsar that referenced this pull request Jun 18, 2025
@lhotari @nodece
[fix][io] Acknowledge RabbitMQ message after processing the message s…
3a7876a 
…uccessfully (apache#24354)

(cherry picked from commit 76c6f6a)
KannarFr pushed a commit to CleverCloud/pulsar that referenced this pull request Sep 22, 2025
@lhotari @KannarFr
[fix][io] Acknowledge RabbitMQ message after processing the message s…
1acfafe 
…uccessfully (apache#24354)
walkinggo pushed a commit to walkinggo/pulsar that referenced this pull request Oct 8, 2025
@lhotari @walkinggo
[fix][io] Acknowledge RabbitMQ message after processing the message s…
8a95b70 
…uccessfully (apache#24354)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dao-jun dao-jun dao-jun approved these changes

@david-streamlio david-streamlio david-streamlio approved these changes

@merlimat merlimat Awaiting requested review from merlimat

Assignees

@lhotari lhotari

Labels

cherry-picked/branch-3.0 cherry-picked/branch-3.3 cherry-picked/branch-4.0 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.13 release/3.3.8 release/4.0.6

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

[Bug] Pulsar IO RabbitMQ source connector might loose messages since it acks to RabbitMQ before message has been handled

4 participants

@lhotari @codecov-commenter @dao-jun @david-streamlio