[fix][broker] Ignore metadata changes when broker is not in the Started state #24352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
requested changes
May 27, 2025
Member
lhotari
left a comment
There was a problem hiding this comment.
This solution won't work when using a dynamic port (0). What NPEs are you seeing?
Member
|
Commented about another way to address the issue: #24312 (comment) |
…ed state Signed-off-by: Zixuan Liu <nodeces@gmail.com>
3 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24352 +/- ##
============================================
+ Coverage 73.57% 74.22% +0.65%
- Complexity 32624 32645 +21
============================================
Files 1877 1866 -11
Lines 139502 145133 +5631
Branches 15299 16596 +1297
============================================
+ Hits 102638 107732 +5094
+ Misses 28908 28879 -29
- Partials 7956 8522 +566
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
nodece
added a commit
to ascentstream/pulsar
that referenced
this pull request
May 28, 2025
…ed state (apache#24352) Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 12c96f6) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 4, 2025
…ed state (apache#24352) Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 12c96f6) (cherry picked from commit 38d71d3)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 4, 2025
…ed state (apache#24352) Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 12c96f6) (cherry picked from commit 1602336)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 4, 2025
…ed state (apache#24352) Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 12c96f6) (cherry picked from commit 38d71d3)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 4, 2025
…ed state (apache#24352) Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 12c96f6) (cherry picked from commit 38d71d3)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 5, 2025
…ed state (apache#24352) Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 12c96f6) (cherry picked from commit 1602336)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 5, 2025
…ed state (apache#24352) Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 12c96f6) (cherry picked from commit 38d71d3)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 10, 2025
…ed state (apache#24352) Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 12c96f6) (cherry picked from commit 38d71d3)
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
…ed state (apache#24352) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
…ed state (apache#24352) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24312
Motivation
The
brokerIdwas previously initialized in thestartmethod, after theBrokerServicehad already started. This could lead to aNullPointerExceptionif thebrokerIdis accessed during the early stages of startup.Modifications
brokerId, please fall back tounknown.Documentation
docdoc-requireddoc-not-neededdoc-complete