-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improve][broker] Deny removing local cluster from topic level replicated cluster policy #24351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
poorbarcode
merged 3 commits into
apache:master
from
poorbarcode:fix/global_policies_deleting
Jun 17, 2025
Merged
[improve][broker] Deny removing local cluster from topic level replicated cluster policy #24351
poorbarcode
merged 3 commits into
apache:master
from
poorbarcode:fix/global_policies_deleting
Jun 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
approved these changes
May 30, 2025
Member
lhotari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4 tasks
Contributor
Author
|
/pulsarbot rerun-failure-checks |
1 similar comment
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Merged
4 tasks
fecbdfd to
5887b36
Compare
coderzc
approved these changes
Jun 16, 2025
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Jun 20, 2025
…ated cluster policy (apache#24351) (cherry picked from commit 82af299)
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 20, 2025
…ated cluster policy (apache#24351) (cherry picked from commit 82af299) (cherry picked from commit 7510a76)
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 21, 2025
…ated cluster policy (apache#24351) (cherry picked from commit 82af299) (cherry picked from commit e0e4d88)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 24, 2025
…ated cluster policy (apache#24351) (cherry picked from commit 82af299) (cherry picked from commit e0e4d88)
ganesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 27, 2025
…ated cluster policy (apache#24351) (cherry picked from commit 82af299) (cherry picked from commit 7510a76)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 30, 2025
…ated cluster policy (apache#24351) (cherry picked from commit 82af299) (cherry picked from commit 7510a76)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Jul 28, 2025
…ated cluster policy (apache#24351) (cherry picked from commit 82af299)
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Jul 28, 2025
…ated cluster policy (apache#24351) (cherry picked from commit 82af299)
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
…ated cluster policy (apache#24351)
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
…ated cluster policy (apache#24351)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.13
release/3.3.8
release/4.0.6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
3scenariosScenario 1
Scenario 2
Set a topic-level replicated clusters that do not contain local cluster is not meaningful, except the following scenario: User has two clusters, which enabled Geo-Replication through a global metadata store, the resources named partitioned topic metadata and the resource namespace-level "replicated clusters" are shared between multi clusters. Pulsar can hardly delete a specify partitioned topic. To support this use case, the following steps can implement it:
TODO But the API "pulsar-admin topics set-replication-clusters" does not support global policy, to support this scenario, a PIP is needed.
Scenario 3
cluster-Awill delete the topics/topic automatically.pulsar-admin topics delete-partitioned-topic <topic>oncluster-B.Modifications
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x