[improve][ml] Offload ledgers without check ledger length #24344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/pulsarbot rerun-failure-checks |
dao-jun
approved these changes
May 23, 2025
Member
dao-jun
left a comment
There was a problem hiding this comment.
maybe we need to fix the bk bug, but the PR still makes sense
lhotari
approved these changes
May 26, 2025
lhotari
reviewed
May 26, 2025
.../org/apache/bookkeeper/mledger/offload/filesystem/impl/FileSystemManagedLedgerOffloader.java
Outdated
Show resolved
Hide resolved
lhotari
reviewed
May 26, 2025
.../org/apache/bookkeeper/mledger/offload/filesystem/impl/FileSystemManagedLedgerOffloader.java
Outdated
Show resolved
Hide resolved
lhotari
reviewed
May 26, 2025
.../java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlobStoreManagedLedgerOffloader.java
Outdated
Show resolved
Hide resolved
…/mledger/offload/filesystem/impl/FileSystemManagedLedgerOffloader.java Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com>
…ger/offload/jcloud/impl/BlobStoreManagedLedgerOffloader.java Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com>
lhotari
approved these changes
May 26, 2025
Member
|
/pulsarbot rerun-failure-checks |
nodece
approved these changes
May 27, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24344 +/- ##
============================================
+ Coverage 73.57% 74.23% +0.65%
+ Complexity 32624 2404 -30220
============================================
Files 1877 1866 -11
Lines 139502 145141 +5639
Branches 15299 16597 +1298
============================================
+ Hits 102638 107744 +5106
+ Misses 28908 28882 -26
- Partials 7956 8515 +559
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
poorbarcode
added a commit
that referenced
this pull request
May 29, 2025
Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com> (cherry picked from commit 3ccea6a)
poorbarcode
added a commit
that referenced
this pull request
May 29, 2025
Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com> (cherry picked from commit 3ccea6a)
poorbarcode
added a commit
that referenced
this pull request
May 29, 2025
Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com> (cherry picked from commit 3ccea6a)
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Jun 18, 2025
Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com> (cherry picked from commit 3ccea6a)
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com>
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
Co-authored-by: Lari Hotari <lhotari@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Bookie has bugs that Ledger may close with a zero length, even if it has entries, such as [fix] Write stuck due to pending add callback by multiple threads bookkeeper#4557. See example[1]
Since a Pulsar message at least contains message metadata, Pulsar will never write entries to BKs with an empty payload, we can confirm the ledger will never be empty when
ledger.entreisis larger than0.The offloading tasks checks both
ledger lengthandentries, which prevents offloading and throws an errorjava.util.concurrent.CompletionException: java.lang.IllegalArgumentException: An empty or open ledger should never be offloaded[1]: ledger close with a zero length, but it has
320entriesModifications
Skip the checking of
ledger.length, just checkledger.entres, and print a warn log if a ledger's length is not expected,Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x