[fix][offload] Complete the future outside of the reading loop in BlobStoreBackedReadHandleImplV2.readAsync #24331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
.../java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlobStoreBackedReadHandleImplV2.java
Show resolved
Hide resolved
heesung-sohn
approved these changes
May 21, 2025
nodece
approved these changes
May 22, 2025
dao-jun
approved these changes
May 22, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24331 +/- ##
============================================
+ Coverage 73.57% 74.23% +0.66%
+ Complexity 32624 32204 -420
============================================
Files 1877 1866 -11
Lines 139502 145124 +5622
Branches 15299 16593 +1294
============================================
+ Hits 102638 107738 +5100
+ Misses 28908 28860 -48
- Partials 7956 8526 +570
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 4, 2025
…bStoreBackedReadHandleImplV2.readAsync (apache#24331) (cherry picked from commit bdf6277) (cherry picked from commit b23b451)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 4, 2025
…bStoreBackedReadHandleImplV2.readAsync (apache#24331) (cherry picked from commit bdf6277) (cherry picked from commit ecf6164)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 4, 2025
…bStoreBackedReadHandleImplV2.readAsync (apache#24331) (cherry picked from commit bdf6277) (cherry picked from commit b23b451)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 4, 2025
…bStoreBackedReadHandleImplV2.readAsync (apache#24331) (cherry picked from commit bdf6277) (cherry picked from commit b23b451)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 5, 2025
…bStoreBackedReadHandleImplV2.readAsync (apache#24331) (cherry picked from commit bdf6277) (cherry picked from commit ecf6164)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 5, 2025
…bStoreBackedReadHandleImplV2.readAsync (apache#24331) (cherry picked from commit bdf6277) (cherry picked from commit b23b451)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 10, 2025
…bStoreBackedReadHandleImplV2.readAsync (apache#24331) (cherry picked from commit bdf6277) (cherry picked from commit b23b451)
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Jun 18, 2025
…bStoreBackedReadHandleImplV2.readAsync (apache#24331) (cherry picked from commit bdf6277)
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
…bStoreBackedReadHandleImplV2.readAsync (apache#24331)
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
…bStoreBackedReadHandleImplV2.readAsync (apache#24331)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There's a bug in
BlobStoreBackedReadHandleImplV2.readAsyncwhich can be reproduced withthe existing test
BlobStoreManagedLedgerOffloaderStreamingTest#testReadAndWriteAcrossSegment.The test is flaky and could result in a
ConcurrentModificationException.While investigating this, I noticed that this is a real bug in production code.
It looks like this only impacts "streaming offload" implementation, "PIP 76: Streaming Offload".
It's a bit confusing since it looks like PIP-76 was never fully completed. I don't see any calls to
org.apache.bookkeeper.mledger.LedgerOffloader#streamingOffloadmethod in production code. Similarly, there's noorg.apache.bookkeeper.mledger.LedgerOffloader#readOffloadedmethod calls in production code.Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete