[fix][broker]Non-global topic policies and global topic policies overwrite each other #24286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/pulsarbot rerun-failure-checks |
gaoran10
reviewed
May 21, 2025
...ker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java
Outdated
Show resolved
Hide resolved
Technoboy-
approved these changes
May 21, 2025
gaoran10
approved these changes
May 21, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #24286 +/- ##
============================================
+ Coverage 73.57% 74.24% +0.66%
+ Complexity 32624 32257 -367
============================================
Files 1877 1866 -11
Lines 139502 145124 +5622
Branches 15299 16593 +1294
============================================
+ Hits 102638 107746 +5108
+ Misses 28908 28836 -72
- Partials 7956 8542 +586
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 4, 2025
…write each other (apache#24286) (cherry picked from commit 6662471)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 4, 2025
…write each other (apache#24286) (cherry picked from commit 6662471) (cherry picked from commit 323e2ff)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 4, 2025
…write each other (apache#24286) (cherry picked from commit 6662471) (cherry picked from commit 5cfd804)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 4, 2025
…write each other (apache#24286) (cherry picked from commit 6662471) (cherry picked from commit 5cfd804)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 5, 2025
…write each other (apache#24286) (cherry picked from commit 6662471) (cherry picked from commit 5cfd804)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 5, 2025
…write each other (apache#24286) (cherry picked from commit 6662471) (cherry picked from commit 5cfd804)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 5, 2025
…write each other (apache#24286) (cherry picked from commit 6662471) (cherry picked from commit 5cfd804)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 5, 2025
…write each other (apache#24286) (cherry picked from commit 6662471) (cherry picked from commit 323e2ff)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 10, 2025
…write each other (apache#24286) (cherry picked from commit 6662471) (cherry picked from commit 5cfd804)
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Jun 18, 2025
…write each other (apache#24286) (cherry picked from commit 6662471)
Member
|
@poorbarcode It seems that this change should be covered with a PIP. Do you agree? |
Contributor
Author
Could you explain why it is needed? |
Member
This PR changed the way how topic policies are stored. It would be useful to have such details documented in PIPs. This change was also cherry-picked to maintenance branches and it would be useful to document the backwards compatibility in the PIP document. |
Denovo1998
reviewed
Jul 29, 2025
Comment on lines
+229
to
+232
| CompletableFuture<MessageId> deletePolicies = writer.deleteAsync(getEventKey(event, true), event) | ||
| .thenCompose(__ -> { | ||
| return writer.deleteAsync(getEventKey(event, false), event); | ||
| }); |
Contributor
There was a problem hiding this comment.
@poorbarcode @lhotari It's a bit strange, why isn't CompletableFuture.allOf used here?
Contributor
Author
There was a problem hiding this comment.
I think using CompletableFuture.allOf can benefit the performance. Thanks for mentioning this improvement
Contributor
There was a problem hiding this comment.
Of course, you can submit a small PR later.
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Issue 1: Non-global topic policies and global topic policies overwrite each other
20001000__change_events1000Issue 2: Global policy can not be removed successfully
1000Modifications
Fix two issues
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x