Skip to content

Conversation

@JunFu0814
Copy link
Contributor

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added PIP doc-not-needed Your PR changes do not impact docs labels May 8, 2025
@dao-jun dao-jun changed the title [improve][pip] PIP-416: Add a new topic method to implement trigger o… [improve][pip] PIP-416: Add a new topic method to implement trigger offload by size threshold May 8, 2025
Copy link
Contributor

@liangyepianzhou liangyepianzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This vote is closed with one +1(binding) and two +1(non-binding). Moreover, it has only been 11 days since the vote was initiated, so we should wait for more feedback from the PMC.
https://lists.apache.org/thread/mzl2mdbylhz4fb5l55pmgyqjszrhop6l

@JunFu0814
Copy link
Contributor Author

Hi @lhotari , I've submitted a pip for adding a new Pulsar client method that can manually trigger a topic-level offload based on a size threshold. Can you review it when you have time? Looking forward to your suggestions. Thanks!

@JunFu0814
Copy link
Contributor Author

Hi @lhotari , I've submitted a pip for adding a new Pulsar client method that can manually trigger a topic-level offload based on a size threshold. Can you review it when you have time? Looking forward to your suggestions. Thanks!

Looking forward to your suggestions for this pip! @lhotari

Copy link
Member

@nodece nodece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this PIP has been passed with +1(binding).

@liangyepianzhou This PIP follows the vote rule:

Everyone is welcome to vote on the proposal, though only the vote of the PMC members will be considered binding. The requirement is to have at least one binding +1 vote from a lazy majority if no binding -1 votes have been cast on the PIP. The vote should stay open for at least 48 hours.

@nodece nodece requested a review from liangyepianzhou June 13, 2025 10:24
@nodece nodece added this to the 4.1.0 milestone Jun 13, 2025
@nodece nodece dismissed liangyepianzhou’s stale review June 16, 2025 07:07

no recent activity.

@nodece nodece closed this Jun 16, 2025
@nodece nodece reopened this Jun 16, 2025
@nodece nodece merged commit 7702bde into apache:master Jun 16, 2025
22 checks passed
KannarFr pushed a commit to CleverCloud/pulsar that referenced this pull request Sep 22, 2025
…ffload by size threshold (apache#24276)

Co-authored-by: fujun <shoyo0814@163.com>
walkinggo pushed a commit to walkinggo/pulsar that referenced this pull request Oct 8, 2025
…ffload by size threshold (apache#24276)

Co-authored-by: fujun <shoyo0814@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs PIP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants