[improve][misc] Upgrade Guava to 33.4.8 that uses JSpecify annotations #24267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodece
approved these changes
May 7, 2025
dao-jun
approved these changes
May 7, 2025
c0fedab to
934f3b2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24267 +/- ##
============================================
+ Coverage 73.57% 74.32% +0.74%
+ Complexity 32624 32608 -16
============================================
Files 1877 1876 -1
Lines 139502 146270 +6768
Branches 15299 16773 +1474
============================================
+ Hits 102638 108713 +6075
- Misses 28908 28921 +13
- Partials 7956 8636 +680
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Newer Guava versions have switched to use JSpecify annotations and avoid direct "Unsafe" usage (replaced with AtomicFieldUpdater usage).
The suggestion is to upgrade Guava in the master branch.
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete