Skip to content

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented May 2, 2025

Motivation & Modifications

  • Upgrade Mockito to 5.17.0 and byte-buddy to 1.15.11 so that Java 24 byte code is supported.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 4.1.0 milestone May 2, 2025
@lhotari lhotari self-assigned this May 2, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 2, 2025
@lhotari lhotari force-pushed the lh-upgrade-mockito-to-support-jdk-24 branch 4 times, most recently from 34fc3a4 to 532db8b Compare May 5, 2025 20:30
@lhotari lhotari force-pushed the lh-upgrade-mockito-to-support-jdk-24 branch 2 times, most recently from 5ca1466 to 4a5093d Compare May 6, 2025 19:13
@lhotari lhotari marked this pull request as draft May 7, 2025 05:39
@lhotari
Copy link
Member Author

lhotari commented May 7, 2025

Marking as draft until #24261 is merged since the test becomes very flaky with Mockito 5.17.

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.24%. Comparing base (bbc6224) to head (4a5093d).
Report is 1080 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #24241      +/-   ##
============================================
+ Coverage     73.57%   74.24%   +0.66%     
+ Complexity    32624    32218     -406     
============================================
  Files          1877     1866      -11     
  Lines        139502   144978    +5476     
  Branches      15299    16561    +1262     
============================================
+ Hits         102638   107638    +5000     
+ Misses        28908    28816      -92     
- Partials       7956     8524     +568     
Flag Coverage Δ
inttests 26.75% <ø> (+2.16%) ⬆️
systests 23.35% <ø> (-0.98%) ⬇️
unittests 73.71% <ø> (+0.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1082 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari lhotari marked this pull request as ready for review May 7, 2025 11:11
@lhotari lhotari merged commit 83dea9e into apache:master May 7, 2025
52 of 53 checks passed
lhotari added a commit that referenced this pull request May 9, 2025
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 14, 2025
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request May 14, 2025
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request May 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants