[fix][test] Fix flaky DisabledCreateTopicToRemoteClusterForReplicationTest #24141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…licationTest.testCreatePartitionedTopicWithNsReplication
Contributor
Author
lhotari
reviewed
Mar 28, 2025
...a/org/apache/pulsar/broker/service/DisabledCreateTopicToRemoteClusterForReplicationTest.java
Outdated
Show resolved
Hide resolved
lhotari
approved these changes
Apr 1, 2025
Member
|
It's possible that this doesn't address the flakiness. 10 seconds is already a long timeout so unless there's an explanation why it times out, it's not clear why increasing to 20 seconds would help. |
crossoverJie
approved these changes
Apr 5, 2025
4 tasks
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23827
Motivation
fix flaky-test, I think the flaky-test is due to replication not complete yet within 10 seconds, so I added to 30 seconds and change the assertion into await().atMost(30, TimeUnit.SECONDS)
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: 3pacccccc#2