[fix][broker] Avoid IllegalStateException when marker_type field is not set in publishing #24087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot set in publishing
3 tasks
nodece
approved these changes
Mar 17, 2025
dao-jun
approved these changes
Mar 17, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24087 +/- ##
============================================
+ Coverage 73.57% 74.18% +0.61%
+ Complexity 32624 32059 -565
============================================
Files 1877 1863 -14
Lines 139502 144313 +4811
Branches 15299 16457 +1158
============================================
+ Hits 102638 107065 +4427
+ Misses 28908 28793 -115
- Partials 7956 8455 +499
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
…ot set in publishing (apache#24087)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As described in #24085, the changes in #23697 broke compatibility with existing protocol adapters.
Modifications
Avoid the IllegalStateException mentioned in #24085. This PR doesn't guarantee that there is compatibility, it simply addresses a single issue introduced by #23697 .
Documentation
docdoc-requireddoc-not-neededdoc-complete