Skip to content

Conversation

@zhanghaou
Copy link
Contributor

Motivation

After the topic compaction is triggered, the corresponding Compaction Write Latency metric in the monitoring system remains at 0.

There is no trigger for the Compaction Write Latency refresh() interface. The StatsBuckets.addAll() method only copies the values into the corresponding bucket, but the values in the bucket need to be updated by calling the refresh interface.

Modifications

Add writeLatencyStats.refresh() in getCompactionLatencyStats();

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 10, 2025
@crossoverJie crossoverJie requested a review from nodece March 11, 2025 03:04
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodece nodece merged commit 2eff40f into apache:master Mar 14, 2025
60 of 61 checks passed
lhotari pushed a commit that referenced this pull request Mar 17, 2025
…s be 0 (#24067)

Co-authored-by: 张浩 <zhanghao60@100.me>
(cherry picked from commit 2eff40f)
lhotari pushed a commit that referenced this pull request Mar 17, 2025
…s be 0 (#24067)

Co-authored-by: 张浩 <zhanghao60@100.me>
(cherry picked from commit 2eff40f)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 21, 2025
…s be 0 (apache#24067)

Co-authored-by: 张浩 <zhanghao60@100.me>
(cherry picked from commit 2eff40f)
(cherry picked from commit 8554ee4)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 21, 2025
…s be 0 (apache#24067)

Co-authored-by: 张浩 <zhanghao60@100.me>
(cherry picked from commit 2eff40f)
(cherry picked from commit 8554ee4)
nodece pushed a commit to nodece/pulsar that referenced this pull request Mar 27, 2025
…s be 0 (apache#24067)

Co-authored-by: 张浩 <zhanghao60@100.me>
(cherry picked from commit 2eff40f)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 29, 2025
…s be 0 (apache#24067)

Co-authored-by: 张浩 <zhanghao60@100.me>
(cherry picked from commit 2eff40f)
(cherry picked from commit 97f7c13)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 31, 2025
…s be 0 (apache#24067)

Co-authored-by: 张浩 <zhanghao60@100.me>
(cherry picked from commit 2eff40f)
(cherry picked from commit 97f7c13)
walkinggo pushed a commit to walkinggo/pulsar that referenced this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants