-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][broker] http metric endpoint get compaction latency stats always be 0 #24067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
approved these changes
Mar 14, 2025
Member
lhotari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4 tasks
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 21, 2025
…s be 0 (apache#24067) Co-authored-by: 张浩 <zhanghao60@100.me> (cherry picked from commit 2eff40f) (cherry picked from commit 8554ee4)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 21, 2025
…s be 0 (apache#24067) Co-authored-by: 张浩 <zhanghao60@100.me> (cherry picked from commit 2eff40f) (cherry picked from commit 8554ee4)
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Mar 27, 2025
…s be 0 (apache#24067) Co-authored-by: 张浩 <zhanghao60@100.me> (cherry picked from commit 2eff40f)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 29, 2025
…s be 0 (apache#24067) Co-authored-by: 张浩 <zhanghao60@100.me> (cherry picked from commit 2eff40f) (cherry picked from commit 97f7c13)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 31, 2025
…s be 0 (apache#24067) Co-authored-by: 张浩 <zhanghao60@100.me> (cherry picked from commit 2eff40f) (cherry picked from commit 97f7c13)
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
…s be 0 (apache#24067) Co-authored-by: 张浩 <zhanghao60@100.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.11
release/4.0.4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After the topic compaction is triggered, the corresponding Compaction Write Latency metric in the monitoring system remains at 0.
There is no trigger for the Compaction Write Latency refresh() interface. The StatsBuckets.addAll() method only copies the values into the corresponding bucket, but the values in the bucket need to be updated by calling the refresh interface.
Modifications
Add writeLatencyStats.refresh() in getCompactionLatencyStats();
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: