Skip to content

[improve] Upgrade lombok to 1.18.36 #23752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodece merged 1 commit into from
Dec 18, 2024
Merged

[improve] Upgrade lombok to 1.18.36 #23752

nodece merged 1 commit into from
Dec 18, 2024

Conversation

@nodece
Copy link
Member

@nodece nodece commented Dec 18, 2024

Motivation

Keep up-to-date.

Change log: https://projectlombok.org/changelog

Using the 1.18.36 can avoid the following error when using the idea runs the tests directly:

java: Lombok annotation handler class lombok.javac.handlers.HandleToString failed on repo/pulsar/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java: java.lang.StackOverflowError

Modifications

  • Upgrade lombok from 1.18.32 to 1.18.36.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@nodece
[improve] Upgrade lombok to 1.18.36
a2400cd 
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nodece nodece self-assigned this Dec 18, 2024
@nodece nodece requested review from dao-jun and lhotari December 18, 2024 07:23
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 18, 2024
lhotari
lhotari approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari added this to the 4.1.0 milestone Dec 18, 2024
@lhotari
Copy link
Member

lhotari commented Dec 18, 2024

btw. regarding the StackOverflowError, the config in .mvn/jvm.config with -Xss1500k has been a workaround for this problem. We can keep that setting even if Lombok has improved since it's not causing any issues to increase the default stack size from 1MB to 1500kB.
I have forgotten to document this workaround in IntelliJ compiler:
image

@nodece
Copy link
Member Author

nodece commented Dec 18, 2024

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.29%. Comparing base (bbc6224) to head (a2400cd).
Report is 800 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23752      +/-   ##
============================================
+ Coverage     73.57%   74.29%   +0.72%     
+ Complexity    32624    32115     -509     
============================================
  Files          1877     1838      -39     
  Lines        139502   143048    +3546     
  Branches      15299    16232     +933     
============================================
+ Hits         102638   106281    +3643     
+ Misses        28908    28406     -502     
- Partials       7956     8361     +405
Flag Coverage Δ
inttests 26.86% <ø> (+2.27%) ⬆️
systests 23.68% <ø> (-0.65%) ⬇️
unittests 73.66% <ø> (+0.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1002 files with indirect coverage changes

@nodece nodece merged commit 1c9bf82 into apache:master Dec 18, 2024
53 of 56 checks passed
@nodece nodece deleted the upgrade-lombok-1.18.36 branch December 18, 2024 09:17
nodece added a commit that referenced this pull request Dec 18, 2024
@nodece
[improve] Upgrade lombok to 1.18.36 (#23752)
cdd1517 
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit 1c9bf82)
nodece added a commit that referenced this pull request Dec 18, 2024
@nodece
[improve] Upgrade lombok to 1.18.36 (#23752)
0c6ce59 
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit 1c9bf82)
nodece added a commit that referenced this pull request Dec 18, 2024
@nodece
[improve] Upgrade lombok to 1.18.36 (#23752)
e207271 
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit 1c9bf82)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Dec 19, 2024
@nodece @nikhil-ctds
[improve] Upgrade lombok to 1.18.36 (apache#23752)
ef34e00 
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit 1c9bf82)
(cherry picked from commit cdd1517)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Dec 21, 2024
@nodece @nikhil-ctds
[improve] Upgrade lombok to 1.18.36 (apache#23752)
9aba771 
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit 1c9bf82)
(cherry picked from commit cdd1517)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Dec 23, 2024
@nodece @srinath-ctds
[improve] Upgrade lombok to 1.18.36 (apache#23752)
c971c87 
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit 1c9bf82)
(cherry picked from commit cdd1517)
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
@nodece @hanmz
[improve] Upgrade lombok to 1.18.36 (apache#23752)
289ed28 
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhotari lhotari lhotari approved these changes

@dao-jun dao-jun dao-jun approved these changes

Assignees

@nodece nodece

Labels

area/build cherry-picked/branch-3.0 cherry-picked/branch-3.3 cherry-picked/branch-4.0 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.9 release/3.3.4 release/4.0.2

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@nodece @lhotari @codecov-commenter @dao-jun