Skip to content

[improve] Upgrade oxia-java to 0.4.10 and fix closing of OxiaMetadataStore #23653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lhotari merged 1 commit into from
Nov 28, 2024
Merged

[improve] Upgrade oxia-java to 0.4.10 and fix closing of OxiaMetadataStore #23653

lhotari merged 1 commit into from
Nov 28, 2024

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Nov 28, 2024

Motivation

  • oxia-java 0.4.10 switches from javax.annotation to jakarta.annotation
  • OxiaMetadataStore close isn't properly changing the state to closed

Modifications

  • upgrade to oxia-java 0.4.10
  • fix OxiaMetadataStore.close

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 4.1.0 milestone Nov 28, 2024
@lhotari lhotari self-assigned this Nov 28, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.34%. Comparing base (bbc6224) to head (c92d529).
Report is 767 commits behind head on master.

Files with missing lines Patch % Lines
...e/pulsar/metadata/impl/oxia/OxiaMetadataStore.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23653      +/-   ##
============================================
+ Coverage     73.57%   74.34%   +0.76%     
- Complexity    32624    35008    +2384     
============================================
  Files          1877     1944      +67     
  Lines        139502   147239    +7737     
  Branches      15299    16250     +951     
============================================
+ Hits         102638   109460    +6822     
- Misses        28908    29335     +427     
- Partials       7956     8444     +488
Flag Coverage Δ
inttests 27.19% <50.00%> (+2.61%) ⬆️
systests 24.31% <0.00%> (-0.01%) ⬇️
unittests 73.73% <75.00%> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...e/pulsar/metadata/impl/oxia/OxiaMetadataStore.java 87.83% <75.00%> (-2.17%) ⬇️

... and 661 files with indirect coverage changes

@lhotari lhotari changed the title [improve][metadata] Upgrade oxia-java to 0.4.10 and fix closing of OxiaMetadataStore [improve] Upgrade oxia-java to 0.4.10 and fix closing of OxiaMetadataStore Nov 28, 2024
@lhotari lhotari merged commit 7e6fa55 into apache:master Nov 28, 2024
54 of 59 checks passed
lhotari added a commit that referenced this pull request Nov 28, 2024
@lhotari
[improve] Upgrade oxia-java to 0.4.10 and fix closing of OxiaMetadata…
2c05137 
…Store (#23653)

(cherry picked from commit 7e6fa55)
lhotari added a commit that referenced this pull request Nov 28, 2024
@lhotari
[improve] Upgrade oxia-java to 0.4.10 and fix closing of OxiaMetadata…
49e6f06 
…Store (#23653)

(cherry picked from commit 7e6fa55)
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
@lhotari @hanmz
[improve] Upgrade oxia-java to 0.4.10 and fix closing of OxiaMetadata…
e6a640e 
…Store (apache#23653)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobertIndie RobertIndie RobertIndie approved these changes

@merlimat merlimat Awaiting requested review from merlimat

@Technoboy- Technoboy- Awaiting requested review from Technoboy-

@nodece nodece Awaiting requested review from nodece

@dao-jun dao-jun Awaiting requested review from dao-jun

@thetumbled thetumbled Awaiting requested review from thetumbled

@mattisonchao mattisonchao Awaiting requested review from mattisonchao

@heesung-sohn heesung-sohn Awaiting requested review from heesung-sohn

@hezhangjian hezhangjian Awaiting requested review from hezhangjian

@BewareMyPower BewareMyPower Awaiting requested review from BewareMyPower

@Demogorgon314 Demogorgon314 Awaiting requested review from Demogorgon314

@nicoloboschi nicoloboschi Awaiting requested review from nicoloboschi

@poorbarcode poorbarcode Awaiting requested review from poorbarcode

@eolivelli eolivelli Awaiting requested review from eolivelli

@coderzc coderzc Awaiting requested review from coderzc

@shibd shibd Awaiting requested review from shibd

Assignees

@lhotari lhotari

Labels

cherry-picked/branch-3.3 cherry-picked/branch-4.0 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.3.3 release/4.0.1

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@lhotari @codecov-commenter @RobertIndie