[feat][broker] Prevent auto-creation of topics using legacy cluster-based naming scheme #23620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 21, 2024 11:59
…ster name in its name
…ster name in its name
lhotari
reviewed
Nov 21, 2024
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
Outdated
Show resolved
Hide resolved
Member
|
Related to #23594 |
4 tasks
Jason918
requested changes
Dec 3, 2024
...roker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceAutoTopicCreationTest.java
Show resolved
Hide resolved
Jason918
requested changes
Dec 4, 2024
...roker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceAutoTopicCreationTest.java
Outdated
Show resolved
Hide resolved
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
Outdated
Show resolved
Hide resolved
added 7 commits
December 4, 2024 10:59
Jason918
reviewed
Dec 4, 2024
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23620 +/- ##
============================================
+ Coverage 73.57% 74.16% +0.59%
+ Complexity 32624 32153 -471
============================================
Files 1877 1853 -24
Lines 139502 143385 +3883
Branches 15299 16279 +980
============================================
+ Hits 102638 106343 +3705
+ Misses 28908 28687 -221
- Partials 7956 8355 +399
Flags with carried forward coverage won't be shown. Click here to find out more.
|
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…ased naming scheme (apache#23620) Co-authored-by: zjxxzjwang <zjxxzjwang@tencent.com>
Contributor
|
This PR introduced a new config without any PIP. Currently it's not cherry-picked into any existing branch. But we should consider adding a PIP for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Topic name rule
old version: {tenant}/{cluster}/{namespace}/{topic}
new version: {tenant}/{namespace}/{topic}
If the name of an automatically created topic contains a "/", the topic will be resolved into a four-segment format (containing a layer of cluster directories). As a result, the automatically created topic does not conform to the latest topic naming rules
Modifications
No allowto automatically create topic names that contain slashes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: