[fix][broker] Ensure that PulsarService is ready for serving incoming requests #22977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Member
|
Is this possible for us to start WebService/WebSocketService/BrokerService/ProtocolHander after the other Pulsar Services start? |
Member
Author
Yes, it makes sense to cover all cases in a way so that requests aren't handled before PulsarService has been started. |
49ae27c to
1238a4f
Compare
Member
Author
I renamed the concept to mean that the broker is ready to serve request instead of being fully started. I believe that this covers what is really needed and the original intention of this PR. I checked the current solution and this is sufficiently covered already for the Pulsar broker with various configurations. There's no need to separately handle websockets since websocket servlets get added to the same Jetty server which already contains the filter to wait until PulsarService is ready for incoming requests. ProtocolHandlers don't need any special handling since they get started as the last step in PulsarService. |
1238a4f to
16c69f1
Compare
16c69f1 to
09a46e4
Compare
3 tasks
14c17a0 to
3ab5526
Compare
3ab5526 to
fc593e7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22977 +/- ##
============================================
- Coverage 73.57% 73.39% -0.18%
- Complexity 32624 32915 +291
============================================
Files 1877 1903 +26
Lines 139502 142711 +3209
Branches 15299 15571 +272
============================================
+ Hits 102638 104749 +2111
- Misses 28908 29941 +1033
- Partials 7956 8021 +65
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
heesung-sohn
approved these changes
Jun 26, 2024
heesung-sohn
pushed a commit
to heesung-sohn/pulsar
that referenced
this pull request
Jun 26, 2024
… requests (apache#22977) (cherry picked from commit 53df683)
heesung-sohn
pushed a commit
to heesung-sohn/pulsar
that referenced
this pull request
Jun 26, 2024
… requests (apache#22977) (cherry picked from commit 53df683)
heesung-sohn
pushed a commit
to heesung-sohn/pulsar
that referenced
this pull request
Jun 26, 2024
… requests (apache#22977) (cherry picked from commit 53df683) (cherry picked from commit ec51420)
heesung-sohn
pushed a commit
to heesung-sohn/pulsar
that referenced
this pull request
Jun 26, 2024
… requests (apache#22977) (cherry picked from commit 53df683)
heesung-sohn
pushed a commit
to heesung-sohn/pulsar
that referenced
this pull request
Jun 26, 2024
… requests (apache#22977) (cherry picked from commit 53df683)
heesung-sohn
pushed a commit
to heesung-sohn/pulsar
that referenced
this pull request
Jun 26, 2024
… requests (apache#22977) (cherry picked from commit 53df683)
heesung-sohn
pushed a commit
to heesung-sohn/pulsar
that referenced
this pull request
Jun 26, 2024
… requests (apache#22977) (cherry picked from commit 53df683) (cherry picked from commit ec51420)
heesung-sohn
pushed a commit
to heesung-sohn/pulsar
that referenced
this pull request
Jun 26, 2024
… requests (apache#22977) (cherry picked from commit 53df683) (cherry picked from commit ec51420)
heesung-sohn
pushed a commit
to heesung-sohn/pulsar
that referenced
this pull request
Jun 26, 2024
… requests (apache#22977) (cherry picked from commit 53df683)
heesung-sohn
pushed a commit
to heesung-sohn/pulsar
that referenced
this pull request
Jun 27, 2024
…incoming requests (apache#22977)" This reverts commit 598e073.
heesung-sohn
pushed a commit
to heesung-sohn/pulsar
that referenced
this pull request
Jun 27, 2024
… requests (apache#22977) (cherry picked from commit 53df683) (cherry picked from commit ec51420)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 27, 2024
… requests (apache#22977) (cherry picked from commit 53df683) (cherry picked from commit ec51420) (cherry picked from commit 1a7eb54)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 1, 2024
… requests (apache#22977) (cherry picked from commit 53df683) (cherry picked from commit ec51420) (cherry picked from commit 1a7eb54)
3 tasks
4 tasks
4 tasks
This was referenced Sep 6, 2024
Merged
4 tasks
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22975
Motivation
Pulsar broker will start serving requests while the broker is starting. This can cause issues and bugs which are hard to reproduce. Serving requests should be delayed until the broker is ready.
The
brokerIdbug #22975 is just one example of problems that this PR will address.Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete