Skip to content

Conversation

@dao-jun
Copy link
Member

@dao-jun dao-jun commented Jun 16, 2024

Motivation

upgrade RoaringBitmap to 1.0.6

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@dao-jun dao-jun added area/dependency Pull requests that update a dependency file ready-to-test dependencies Pull requests that update a dependency file labels Jun 16, 2024
@dao-jun dao-jun added this to the 3.4.0 milestone Jun 16, 2024
@dao-jun dao-jun self-assigned this Jun 16, 2024
@dao-jun dao-jun requested a review from lhotari June 16, 2024 14:34
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 16, 2024
@lhotari
Copy link
Member

lhotari commented Jun 16, 2024

Error message: "org.roaringbitmap-shims-1.0.6.jar mentioned in LICENSE, but not bundled"

Perhaps that jar no longer exists in 1.0.6 version?

@dao-jun
Copy link
Member Author

dao-jun commented Jun 17, 2024

Error message: "org.roaringbitmap-shims-1.0.6.jar mentioned in LICENSE, but not bundled"

Perhaps that jar no longer exists in 1.0.6 version?

yes, removed

@dao-jun dao-jun merged commit 7020ea2 into apache:master Jun 17, 2024
@dao-jun dao-jun deleted the dev/upgrade_roaringbitmap branch June 17, 2024 05:31
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dependency Pull requests that update a dependency file dependencies Pull requests that update a dependency file doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants