[feat][broker] PIP-264: Enable OpenTelemetry reusable data memory mode #22914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
approved these changes
Jun 15, 2024
pulsar-opentelemetry/src/main/java/org/apache/pulsar/opentelemetry/OpenTelemetryService.java
Outdated
Show resolved
Hide resolved
dao-jun
approved these changes
Jun 16, 2024
lhotari
approved these changes
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIP: https://github.com/apache/pulsar/blob/master/pip/pip-264.md
Motivation
The recently added OpenTelemetry 'reusable data' memory mode allows the OpenTelemetry SDK to reduce the number of memory allocations in between collector runs, at the expense of parallel collection. This is a fair compromise given Pulsar's use-case, and it promises to significantly improve the performance of the metric pipeline.
Modifications
Enables, by default, the OpenTelemetry 'reusable data' export mode. This can be overridden by the user at runtime via Java system property
otel.java.experimental.exporter.memory_modeor environment variableOTEL_JAVA_EXPERIMENTAL_EXPORTER_MEMORY_MODE. See https://opentelemetry.io/docs/languages/java/configuration/#exporters for a few more details on the config.Verifying this change
This change is already covered by existing tests, such as:
org.apache.pulsar.tests.integration.metrics.OpenTelemetrySanityTestDoes this pull request potentially affect one of the following parts:
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: dragosvictor#32