Skip to content

[fix] [broker] Fix typo in PersistentTopicsBase #22904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodece merged 1 commit into from
Jun 14, 2024
Merged

[fix] [broker] Fix typo in PersistentTopicsBase #22904

nodece merged 1 commit into from
Jun 14, 2024

Conversation

@richiefanfan
Copy link
Contributor

@richiefanfan richiefanfan commented Jun 14, 2024 •
edited
Loading

Motivation

Fix typo problem.

Modifications

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 14, 2024
@lhotari
Copy link
Member

lhotari commented Jun 14, 2024

Thanks for the PR @richiefanfan! This is a good way to start Pulsar contributions!
There are tools such as https://github.com/crate-ci/typos which could scan the whole code base at once.
We shouldn't change typos in class names and method names in public APIs without first deprecating. Those should be handled separately case-by-case. All typos in log messages or exception messages could be batched together to fewer PRs.

@Technoboy- Technoboy- added this to the 3.4.0 milestone Jun 14, 2024
@nodece nodece merged commit f122817 into apache:master Jun 14, 2024
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
@richiefanfan @hanmz
[fix] [broker] Fix typo in PersistentTopicsBase (apache#22904)
a464617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@nodece nodece nodece approved these changes

Assignees

@richiefanfan richiefanfan

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@richiefanfan @lhotari @Technoboy- @nodece