Skip to content

[fix][broker] Asynchronously return brokerRegistry.lookupAsync when checking if broker is active(ExtensibleLoadManagerImpl only) #22899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
heesung-sohn merged 1 commit into from
Jun 13, 2024
Merged

[fix][broker] Asynchronously return brokerRegistry.lookupAsync when checking if broker is active(ExtensibleLoadManagerImpl only) #22899

heesung-sohn merged 1 commit into from
Jun 13, 2024

Conversation

@heesung-sohn
Copy link
Contributor

@heesung-sohn heesung-sohn commented Jun 12, 2024

Motivation

  • The broker could falsely return that brokers were inactive too soon if the broker registry cache was empty.

Modifications

  • Asynchronously return brokerRegistry.lookupAsync instead of using future.getNow.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 12, 2024
@heesung-sohn heesung-sohn self-assigned this Jun 12, 2024
Demogorgon314
Demogorgon314 approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@Demogorgon314 Demogorgon314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@heesung-sohn heesung-sohn reopened this Jun 13, 2024
@heesung-sohn heesung-sohn merged commit c2702e9 into apache:master Jun 13, 2024
heesung-sohn added a commit to heesung-sohn/pulsar that referenced this pull request Jun 26, 2024
@heesung-sohn
[fix][broker] Asynchronously return brokerRegistry.lookupAsync when c…
2f77f05 
…hecking if broker is active(ExtensibleLoadManagerImpl only) (apache#22899)

(cherry picked from commit c2702e9)
heesung-sohn added a commit to heesung-sohn/pulsar that referenced this pull request Jun 26, 2024
@heesung-sohn
[fix][broker] Asynchronously return brokerRegistry.lookupAsync when c…
2cf6e51 
…hecking if broker is active(ExtensibleLoadManagerImpl only) (apache#22899)

(cherry picked from commit c2702e9)
heesung-sohn added a commit to heesung-sohn/pulsar that referenced this pull request Jun 26, 2024
@heesung-sohn
[fix][broker] Asynchronously return brokerRegistry.lookupAsync when c…
0305a0c 
…hecking if broker is active(ExtensibleLoadManagerImpl only) (apache#22899)

(cherry picked from commit c2702e9)
(cherry picked from commit 2cf6e51)
heesung-sohn added a commit to heesung-sohn/pulsar that referenced this pull request Jun 26, 2024
@heesung-sohn
[fix][broker] Asynchronously return brokerRegistry.lookupAsync when c…
8b626bd 
…hecking if broker is active(ExtensibleLoadManagerImpl only) (apache#22899)

(cherry picked from commit c2702e9)
heesung-sohn added a commit to heesung-sohn/pulsar that referenced this pull request Jun 26, 2024
@heesung-sohn
[fix][broker] Asynchronously return brokerRegistry.lookupAsync when c…
9dba0d5 
…hecking if broker is active(ExtensibleLoadManagerImpl only) (apache#22899)

(cherry picked from commit c2702e9)
heesung-sohn added a commit to heesung-sohn/pulsar that referenced this pull request Jun 26, 2024
@heesung-sohn
[fix][broker] Asynchronously return brokerRegistry.lookupAsync when c…
1aa7c35 
…hecking if broker is active(ExtensibleLoadManagerImpl only) (apache#22899)

(cherry picked from commit c2702e9)
heesung-sohn added a commit to heesung-sohn/pulsar that referenced this pull request Jun 26, 2024
@heesung-sohn
[fix][broker] Asynchronously return brokerRegistry.lookupAsync when c…
b480c12 
…hecking if broker is active(ExtensibleLoadManagerImpl only) (apache#22899)

(cherry picked from commit c2702e9)
(cherry picked from commit 2cf6e51)
heesung-sohn added a commit to heesung-sohn/pulsar that referenced this pull request Jun 27, 2024
@heesung-sohn
[fix][broker] Asynchronously return brokerRegistry.lookupAsync when c…
9ab3f38 
…hecking if broker is active(ExtensibleLoadManagerImpl only) (apache#22899)

(cherry picked from commit c2702e9)
(cherry picked from commit 2cf6e51)
@heesung-sohn heesung-sohn added this to the 3.4.0 milestone Jun 27, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 27, 2024
@heesung-sohn @nikhil-ctds
[fix][broker] Asynchronously return brokerRegistry.lookupAsync when c…
caebf0f 
…hecking if broker is active(ExtensibleLoadManagerImpl only) (apache#22899)

(cherry picked from commit c2702e9)
(cherry picked from commit 2cf6e51)
(cherry picked from commit 9ab3f38)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 1, 2024
@heesung-sohn @srinath-ctds
[fix][broker] Asynchronously return brokerRegistry.lookupAsync when c…
cd5b194 
…hecking if broker is active(ExtensibleLoadManagerImpl only) (apache#22899)

(cherry picked from commit c2702e9)
(cherry picked from commit 2cf6e51)
(cherry picked from commit 9ab3f38)
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
@heesung-sohn @hanmz
[fix][broker] Asynchronously return brokerRegistry.lookupAsync when c…
b516571 
…hecking if broker is active(ExtensibleLoadManagerImpl only) (apache#22899)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Demogorgon314 Demogorgon314 Demogorgon314 approved these changes

Assignees

@heesung-sohn heesung-sohn

Labels

cherry-picked/branch-3.0 cherry-picked/branch-3.2 cherry-picked/branch-3.3 doc-not-needed Your PR changes do not impact docs release/3.0.6 release/3.2.4 release/3.3.1

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@heesung-sohn @Demogorgon314