Skip to content

Conversation

@merlimat
Copy link
Contributor

Motivation

Upgrading to latest version of IP address parsing lib to get fixes & improvements.

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@merlimat merlimat added this to the 3.4.0 milestone Jun 10, 2024
@merlimat merlimat requested a review from lhotari June 10, 2024 17:48
@merlimat merlimat self-assigned this Jun 10, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 10, 2024
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.21%. Comparing base (bbc6224) to head (aa8e8d4).
Report is 368 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22886      +/-   ##
============================================
- Coverage     73.57%   73.21%   -0.37%     
- Complexity    32624    32985     +361     
============================================
  Files          1877     1891      +14     
  Lines        139502   141943    +2441     
  Branches      15299    15566     +267     
============================================
+ Hits         102638   103921    +1283     
- Misses        28908    29999    +1091     
- Partials       7956     8023      +67     
Flag Coverage Δ
inttests 27.21% <ø> (+2.63%) ⬆️
systests 24.66% <ø> (+0.34%) ⬆️
unittests 72.24% <ø> (-0.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 392 files with indirect coverage changes

@lhotari lhotari merged commit f17d90e into apache:master Jun 10, 2024
lhotari pushed a commit that referenced this pull request Jun 10, 2024
lhotari pushed a commit that referenced this pull request Jun 10, 2024
lhotari pushed a commit that referenced this pull request Jun 10, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 17, 2024
(cherry picked from commit f17d90e)
(cherry picked from commit caf08c2)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 25, 2024
(cherry picked from commit f17d90e)
(cherry picked from commit caf08c2)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 1, 2024
(cherry picked from commit f17d90e)
(cherry picked from commit caf08c2)
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants