Skip to content

Conversation

@dragosvictor
Copy link
Contributor

PIP-264

Motivation

Adds producer related metrics to the OpenTelemetry pipeline.

Modifications

  • Adds the metrics described in [feat][doc] PIP-264: Add OpenTelemetry producer metrics reference pulsar-site#911 to the collector runs.
  • Relocates the metric backend data-sources (Producer#msgIn, Producer#chunkedMessageRate and Producer#msgDrop) from the Producer class to PublisherStatsImpl and NonPersistentPublisherStatsImpl, for a cleaner design.
  • Add field Rate.totalValueAdder keeping track of cumulative values added to the Rate, further simplifying the design.

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • Added basic messaging test in OpenTelemetryProducerStatsTest
  • Updated existing test `` to cover the message drop counter functionality

Does this pull request potentially affect one of the following parts:

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: dragosvictor#25

@dragosvictor dragosvictor marked this pull request as ready for review June 7, 2024 23:52
@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label Jun 7, 2024
@lhotari lhotari added this to the 3.4.0 milestone Jun 9, 2024
@heesung-sohn heesung-sohn merged commit f83dbe9 into apache:master Jun 15, 2024
@dragosvictor dragosvictor deleted the dmisca-pip-264-producer-metrics branch June 15, 2024 00:49
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/metrics doc-required Your PR changes impact docs and you will update later. ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants