[improve] [broker] Fail fast when it failed to create LoadSheddingStrategy instance #22827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5cbfd8d to
5cf83d1
Compare
Member
Author
|
PTAL, thanks. @lhotari @Demogorgon314 @heesung-sn @BewareMyPower |
congbobo184
reviewed
Jun 4, 2024
...r-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java
Outdated
Show resolved
Hide resolved
Demogorgon314
approved these changes
Jun 11, 2024
Member
Author
|
/pulsarbot rerun-failure-checks |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22827 +/- ##
============================================
- Coverage 73.57% 73.24% -0.34%
- Complexity 32624 32638 +14
============================================
Files 1877 1889 +12
Lines 139502 141744 +2242
Branches 15299 15554 +255
============================================
+ Hits 102638 103816 +1178
- Misses 28908 29908 +1000
- Partials 7956 8020 +64
Flags with carried forward coverage won't be shown. Click here to find out more.
|
...r-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java
Outdated
Show resolved
Hide resolved
...r-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java
Outdated
Show resolved
Hide resolved
BewareMyPower
approved these changes
Jun 11, 2024
Member
Author
|
/pulsarbot rerun-failure-checks |
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Jul 23, 2024
…ategy instance (apache#22827) (cherry picked from commit 1770cbc)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Jul 24, 2024
…ategy instance (apache#22827) (cherry picked from commit 1770cbc)
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are two error in method
org.apache.pulsar.broker.loadbalance.impl.ModularLoadManagerImpl#createLoadSheddingStrategy.LoadSheddingStrategyinstead ofPlacementStrategy.ThresholdShedderby default instead ofOverloadShedder.Modifications
Fix these two errors.Fail fast when it failed to create LoadSheddingStrategy.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: