Skip to content

[improve] [broker] PIP-355: Enhancing Broker-Level Metrics for Pulsar #22779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hangc0276 merged 7 commits into from
Jun 12, 2024
Merged

[improve] [broker] PIP-355: Enhancing Broker-Level Metrics for Pulsar #22779

hangc0276 merged 7 commits into from
Jun 12, 2024

Conversation

@hangc0276
Copy link
Contributor

@hangc0276 hangc0276 commented May 25, 2024

Fixes #xyz

Main Issue: #xyz

PIP: #22778

Motivation

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@hangc0276 hangc0276 self-assigned this May 25, 2024
@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label May 25, 2024
@hangc0276 hangc0276 added area/metrics category/functionality Some functions are not working such as get errors release/3.2.4 and removed doc-required Your PR changes impact docs and you will update later. labels May 25, 2024
@hangc0276 hangc0276 added this to the 3.4.0 milestone May 25, 2024
@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label May 25, 2024
dao-jun
dao-jun requested changes May 28, 2024
View reviewed changes
Copy link
Member

@dao-jun dao-jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a few minor comments

@hangc0276 hangc0276 force-pushed the chenhang/add_broker_level_bytes_out_total_metric branch from 4f75356 to ffd4b78 Compare May 30, 2024 09:48
@hangc0276
Copy link
Contributor Author

hangc0276 commented May 30, 2024

@asafm @dao-jun I addressed the comments, please help take a look, thanks.

dao-jun
dao-jun approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@dao-jun dao-jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please fix the ci checks

@hangc0276 hangc0276 merged commit c724f02 into apache:master Jun 12, 2024
hangc0276 added a commit that referenced this pull request Jun 12, 2024
@hangc0276
[improve] [broker] PIP-355: Enhancing Broker-Level Metrics for Pulsar (…
49b0378 
…#22779)

PIP: #22778
(cherry picked from commit c724f02)
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
@hangc0276 @hanmz
[improve] [broker] PIP-355: Enhancing Broker-Level Metrics for Pulsar (…
32b9917 
…apache#22779)

PIP: apache#22778
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asafm asafm asafm left review comments

@hezhangjian hezhangjian hezhangjian approved these changes

@dao-jun dao-jun dao-jun approved these changes

@poorbarcode poorbarcode poorbarcode approved these changes

@lhotari lhotari Awaiting requested review from lhotari

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

@horizonzy horizonzy Awaiting requested review from horizonzy

@zymap zymap Awaiting requested review from zymap

Assignees

@hangc0276 hangc0276

Labels

area/metrics category/functionality Some functions are not working such as get errors cherry-picked/branch-3.3 doc-required Your PR changes impact docs and you will update later. ready-to-test release/3.3.1

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@hangc0276 @asafm @hezhangjian @dao-jun @poorbarcode