[Fix][broker] Limit replication rate based on bytes #22674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
reviewed
May 10, 2024
...r-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentReplicator.java
Outdated
Show resolved
Hide resolved
dao-jun
approved these changes
May 13, 2024
Member
Author
|
/pulsarbot rerun-failure-checks |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22674 +/- ##
============================================
- Coverage 73.57% 73.43% -0.14%
- Complexity 32624 33275 +651
============================================
Files 1877 1907 +30
Lines 139502 142961 +3459
Branches 15299 15582 +283
============================================
+ Hits 102638 104985 +2347
- Misses 28908 29945 +1037
- Partials 7956 8031 +75
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
a3277c3 to
d4c089b
Compare
Member
Author
|
/pulsarbot rerun-failure-checks |
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
d4c089b to
51c5c0d
Compare
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
poorbarcode
pushed a commit
that referenced
this pull request
Jul 7, 2025
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 7f4c0c5)
poorbarcode
pushed a commit
that referenced
this pull request
Jul 7, 2025
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 7f4c0c5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When the replicator rate limit value based on bytes is less than the
org.apache.pulsar.broker.service.persistent.PersistentReplicator#readMaxSizeBytes, this will cause the outgoing bytes to exceed the limit value.The goal is to make outgoing bytes as close to the rate limit value as possible.
Modifications
org.apache.pulsar.broker.service.persistent.PersistentReplicator#getAvailablePermitsreturns the available messages and bytes, and then reads the entries based on that.Verifying this change
The test has been added.
Documentation
docdoc-requireddoc-not-neededdoc-complete