Skip to content

[improve] Retry re-validating ResourceLock with backoff after errors#22617

Merged
merlimat merged 4 commits into
apache:masterfrom
merlimat:metadata-session-reconnect
May 7, 2024
Merged

[improve] Retry re-validating ResourceLock with backoff after errors#22617
merlimat merged 4 commits into
apache:masterfrom
merlimat:metadata-session-reconnect

Conversation

@merlimat

Copy link
Copy Markdown
Contributor

Motivation

The ResourceLock revalidation, after a session expiry, is only getting triggered after the signal of session reconnected. If this is not coming through, there is no further attempt to re-validate and re-acquire the lock.

We should improve the logic to also add timed-based retry logic, with exponential backoff.

Modifications

  • Moved Backoff class from pulsar-client -> pulsar-common so that it can be used from pulsar-metadata module.
  • Added additional time based logic that triggers revalidation

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@merlimat merlimat added this to the 3.3.0 milestone Apr 30, 2024
@merlimat merlimat self-assigned this Apr 30, 2024
@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Apr 30, 2024
@merlimat merlimat changed the title Retry re-validating ResourceLock with backoff after errors [improve] Retry re-validating ResourceLock with backoff after errors Apr 30, 2024

@lhotari lhotari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@merlimat merlimat force-pushed the metadata-session-reconnect branch from a3a709d to 936df56 Compare May 3, 2024 17:18
@merlimat merlimat merged commit 83b86ab into apache:master May 7, 2024
@merlimat merlimat deleted the metadata-session-reconnect branch May 7, 2024 17:37
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request May 13, 2024
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants