Skip to content

[improve][broker] Propagate cause exception in TopicBusyException when applicable#22596

Merged
lhotari merged 1 commit into
apache:masterfrom
lhotari:lh-dont-swallow-exception-in-closing-topic
Apr 26, 2024
Merged

[improve][broker] Propagate cause exception in TopicBusyException when applicable#22596
lhotari merged 1 commit into
apache:masterfrom
lhotari:lh-dont-swallow-exception-in-closing-topic

Conversation

@lhotari

@lhotari lhotari commented Apr 26, 2024

Copy link
Copy Markdown
Member

Motivation

When topic is closing and throws an exception, the exception isn't logged and it's swallowed.
It's better to propagate the cause in TopicBusyException in these cases.

Modifications

  • Add support for cause exception to TopicBusyException
  • Propagate the cause when closing throws an exception

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use release/3.1.4 release/3.2.3 release/3.0.5 labels Apr 26, 2024
@lhotari lhotari added this to the 3.3.0 milestone Apr 26, 2024
@lhotari lhotari self-assigned this Apr 26, 2024
@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Apr 26, 2024

@dao-jun dao-jun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lhotari lhotari merged commit 3b9602c into apache:master Apr 26, 2024
lhotari added a commit that referenced this pull request Apr 26, 2024
lhotari added a commit that referenced this pull request Apr 26, 2024
lhotari added a commit that referenced this pull request Apr 26, 2024
lhotari added a commit that referenced this pull request Apr 26, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request May 13, 2024
…n applicable (apache#22596)

(cherry picked from commit 3b9602c)
(cherry picked from commit d00d715)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request May 16, 2024
…n applicable (apache#22596)

(cherry picked from commit 3b9602c)
(cherry picked from commit d00d715)
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants